Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compositiontest): add composition tests #11

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Feb 9, 2025

Description of your changes

  • add composition tests
  • remove unused providerconfig
  • add default value in xrd
  • update example to have an xr instead of an claim

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

up test run tests/*
  ✓   Parsing tests                                                                                                                                  
  ✓   Checking dependencies
  ✓   Generating language schemas
  ✓   Building functions
  ✓   Building configuration package
  ✓   Pushing embedded functions to local daemon                                                                                                     
  ✓   Assert test-xstoragebucket                                                                                                                     
  ✓   Assert test-xstoragebucket-default                                                                                                             
  ✓   Assert test-xstoragebucket                                                                                                                     
 SUCCESS  
 SUCCESS  Tests Summary:
 SUCCESS  ------------------
 SUCCESS  Total Tests Executed: 3
 SUCCESS  Passed tests:         3
 SUCCESS  Failed tests:         0

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
Copy link
Member

@adamwg adamwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haarchri haarchri merged commit 30f3214 into main Feb 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants