Add: Add index_gt::merge() #572
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just focus on index_gt. index_dense_gt is out of scope of this PR. If we get consensus of implementation approach, we'll be able to implement index_dense_gt::merge() too. This adds mutable `memory_mapped_file_t` and you can create a mutable memory-mapped index with it. You can merge multiple indexes to the mutable memory-mapped index without allocating all data on RAM.
kou
commented
Mar 4, 2025
| @@ -3272,7 +3449,6 @@ class index_gt { | |||
|
|
|||
| // We are loading an empty index, no more work to do | |||
| if (!header.size) { | |||
| reset(); | |||
There was a problem hiding this comment.
This is not related to this PR but I add this PR because I need similar change in view(). If this should be a separated PR, I'll open a separated PR.
We don't need to call reset() here because we don't change anything after the above reset().
Comment on lines
-3423
to
+3619
| serialization_result_t stream_result = load_from_stream( | ||
| [&](void* buffer, std::size_t length) { | ||
| if (offset + length > file.size()) | ||
| return false; | ||
| std::memcpy(buffer, file.data() + offset, length); | ||
| offset += length; | ||
| return true; | ||
| }, | ||
| std::forward<progress_at>(progress)); | ||
|
|
||
| return stream_result; | ||
| is_mutable_ = true; | ||
| return {}; | ||
| } else { | ||
| serialization_result_t io_result = file.open_if_not(); | ||
| if (!io_result) | ||
| return io_result; | ||
|
|
||
| serialization_result_t stream_result = load_from_stream( | ||
| [&](void* buffer, std::size_t length) { | ||
| if (offset + length > file.size()) | ||
| return false; | ||
| std::memcpy(buffer, file.data() + offset, length); | ||
| offset += length; | ||
| return true; | ||
| }, | ||
| std::forward<progress_at>(progress)); | ||
| return stream_result; | ||
| } |
There was a problem hiding this comment.
Indentation is only changed because this is moved to else.
| if (!header.size) { | ||
| reset(); |
There was a problem hiding this comment.
We don't need to call reset() because we don't change anything after the above reset().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#84
This just focus on index_gt. index_dense_gt is out of scope of this PR. If we get consensus of implementation approach, we'll be able to implement index_dense_gt::merge() too.
This adds mutable
memory_mapped_file_tand you can create a mutable memory-mapped index with it. You can merge multiple indexes to the mutable memory-mapped index without allocating all data on RAM.