From 9d593be63404cbb2e14178b4111b268a4fd1a248 Mon Sep 17 00:00:00 2001
From: Peder Hovdan Andresen <107681714+pederhan@users.noreply.github.com>
Date: Fri, 29 Nov 2024 10:21:35 +0100
Subject: [PATCH] ci: Test against Python 3.13, drop 3.8 (#263)

---
 .github/workflows/test.yml       | 2 +-
 docs/plugins/external-plugins.md | 2 +-
 zabbix_cli/app/plugins.py        | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 4cda8357..fb49c659 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -20,11 +20,11 @@ jobs:
     strategy:
       matrix:
         python-version:
-          - '3.8'
           - '3.9'
           - '3.10'
           - '3.11'
           - '3.12'
+          - '3.13'
     steps:
       - name: Checkout
         uses: actions/checkout@v4
diff --git a/docs/plugins/external-plugins.md b/docs/plugins/external-plugins.md
index 63aea68d..7893c504 100644
--- a/docs/plugins/external-plugins.md
+++ b/docs/plugins/external-plugins.md
@@ -51,7 +51,7 @@ authors = [
 version = "0.1.0"
 description = "My first Zabbix CLI plugin"
 readme = "README.md"
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = "MIT"
 dependencies = [
     "zabbix-cli@git+https://github.com/unioslo/zabbix-cli.git",
diff --git a/zabbix_cli/app/plugins.py b/zabbix_cli/app/plugins.py
index 713af2a6..deef8869 100644
--- a/zabbix_cli/app/plugins.py
+++ b/zabbix_cli/app/plugins.py
@@ -87,12 +87,12 @@ def _load_plugins_from_metadata(self, config: Config) -> None:
 
         # HACK: Cast Tuple[Any, ...] result to concrete type.
         # In order to pass type checking on all Python versions,
-        # we need to pretend that we are developing on 3.8 and
+        # we need to pretend that we are developing on 3.9 and
         # using the backport. The problem is that the backport
         # does not define a generic tuple type for the result,
         # and instead just subclasses tuple. So we need to cast
         # the result to the correct type.
-        # This is one of the drawbacks of running in 3.8 mode, but
+        # This is one of the drawbacks of running in 3.9 mode, but
         # it's necessary to ensure we don't introduce features that
         # do not exist in our minimum supported version.
         discovered_plugins = cast(Tuple[EntryPoint], discovered_plugins)