Skip to content

Commit

Permalink
ci: Test against Python 3.13, drop 3.8 (#263)
Browse files Browse the repository at this point in the history
  • Loading branch information
pederhan authored Nov 29, 2024
1 parent b66082b commit 9d593be
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ jobs:
strategy:
matrix:
python-version:
- '3.8'
- '3.9'
- '3.10'
- '3.11'
- '3.12'
- '3.13'
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion docs/plugins/external-plugins.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ authors = [
version = "0.1.0"
description = "My first Zabbix CLI plugin"
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
license = "MIT"
dependencies = [
"zabbix-cli@git+https://github.com/unioslo/zabbix-cli.git",
Expand Down
4 changes: 2 additions & 2 deletions zabbix_cli/app/plugins.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,12 @@ def _load_plugins_from_metadata(self, config: Config) -> None:

# HACK: Cast Tuple[Any, ...] result to concrete type.
# In order to pass type checking on all Python versions,
# we need to pretend that we are developing on 3.8 and
# we need to pretend that we are developing on 3.9 and
# using the backport. The problem is that the backport
# does not define a generic tuple type for the result,
# and instead just subclasses tuple. So we need to cast
# the result to the correct type.
# This is one of the drawbacks of running in 3.8 mode, but
# This is one of the drawbacks of running in 3.9 mode, but
# it's necessary to ensure we don't introduce features that
# do not exist in our minimum supported version.
discovered_plugins = cast(Tuple[EntryPoint], discovered_plugins)
Expand Down

0 comments on commit 9d593be

Please sign in to comment.