Disable logging of health check requests #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this endpoint will be probed very frequently in k8s environments, it makes for a lot of noise in log output if each hit is going to emit a log line.
This commit disables logging in the
HealthCheckHandler, which I think is a small loss considering it'll only ever respond in exactly the same way as long as the API is running. If we implement a more complex health check at a later point in time, I think it would make sense to come back to this and ensure that we log non-good responses, but for now I don't think this needs to be configurable.This PR resolves #272.