Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(faucet): add new paginated GraphQL queries for transfers #2446

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

PablitoAmaral
Copy link
Contributor

@PablitoAmaral PablitoAmaral commented Jul 15, 2024

This PR updates the SQL insert statement to use datetime('now') for the time column instead of TIME(). It also adds new GraphQL queries to enhance the faucet functionality and introduces a maximum limit for paginated calls to improve security and performance.

SQL Insert Statement Update:
Changed the SQL insert to use datetime('now') for better timestamp handling.

New GraphQL Queries:
Unhandled Transfers: Get all unhandled transfers with pagination
Handled Transfers: Get all handled transfers with pagination
Transfers for a Specific Address: Get all transfers for a specific address with pagination

Copy link
Contributor

@KaiserKarel KaiserKarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the paginated calls we should have a max, ideally set with a cli arg. That way, if we ever get DOSed, we can in the cli set the number to 50 or something.

KaiserKarel
KaiserKarel previously approved these changes Jul 15, 2024
@PablitoAmaral PablitoAmaral force-pushed the faucet-queries branch 2 times, most recently from 18dd152 to 03b4294 Compare July 16, 2024 09:54
@KaiserKarel KaiserKarel changed the title feat(queries): add new paginated GraphQL queries for transfers feat(faucet): add new paginated GraphQL queries for transfers Jul 16, 2024
KaiserKarel
KaiserKarel previously approved these changes Jul 16, 2024
@PablitoAmaral PablitoAmaral merged commit fbb770a into main Jul 16, 2024
8 checks passed
@PablitoAmaral PablitoAmaral deleted the faucet-queries branch July 16, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants