Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: packet-forward-middleware #1562

Merged
merged 77 commits into from
Jun 6, 2024
Merged

feat: packet-forward-middleware #1562

merged 77 commits into from
Jun 6, 2024

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented Mar 14, 2024 •
edited
Loading

  • Add processing and handling for PFM memos to UCS01 coswmwasm
  • Forward packet to next channel/port
  • Unwrap the next pfm into the memo
  • Create uniond go module to supplement differed ack
  • Update to cosmwasm 2.0 for nil ack equivalent
  • Return nil ack on PFM received messages
  • Remove fee collection functionality from PFM
  • Implement ICS20 portion of cosmwasm contract
  • Write upgrade migration to include the deferredack module in uniond
  • Support PFM packets originating from evm (first hop through Union)
    • Add memo to ucs01-relay Solidity contract
    • Update ucli to support memo on evm transactions
    • Testing

Consequences of Intermediate Go Module

The introduction of the go module will lead to tech debt that will need to be resolved once async ack is introduced into a released version of cosmwasm.

Once async ack is made available, we'll need to:

  1. Upgrade the contract to no longer use the go module and instead use async ack
  2. Upgrade the node to remove the intermediate module

@PoisonPhang PoisonPhang linked an issue Mar 14, 2024 that may be closed by this pull request
Integrate packet-forward-middleware for USC #1547
Closed
@PoisonPhang PoisonPhang changed the title 1547 integrate packet forward middleware for usc feat: packet-forward-middleware Mar 14, 2024
@cor
Copy link
Contributor

cor commented Mar 15, 2024

Add a storage upgrade to the next migration to initialize PFM

Given that we'll have a consensus breaking change requiring a reboot anyways, feel free to just skip creating a migration

@PoisonPhang PoisonPhang self-assigned this Mar 27, 2024
@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch from 6b23e7b to 96293ec Compare March 27, 2024 15:46
@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch from 96293ec to 1a76501 Compare April 8, 2024 15:20
@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch 2 times, most recently from 0bfdbc2 to a84c86a Compare May 8, 2024 15:44
@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch 2 times, most recently from d76d39c to e5b6dea Compare May 23, 2024 01:21
@PoisonPhang
Copy link
Contributor Author

Testing is temporarily blocked by #1969

@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch 2 times, most recently from d00557d to 7c76d6f Compare May 28, 2024 13:29
@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch 2 times, most recently from b43b0a4 to a8bc027 Compare May 30, 2024 08:13
@PoisonPhang PoisonPhang force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch from 1a3df60 to 2dd8bce Compare June 3, 2024 09:07
PoisonPhang and others added 22 commits June 5, 2024 18:24
@PoisonPhang @aeryz
fix(ucs01-relay): use ack type
951058b
@PoisonPhang @aeryz
feat(ucs01-relay): use sequence to create key
c2ced52
@PoisonPhang @aeryz
fix(ucs01-relay): expect rather than silent fail
6524f02
@PoisonPhang @aeryz
chore(diferred-ack-api): update cosmwasm-std
32dbf87
@PoisonPhang @aeryz
fix(ucs01-relay): expect msg inclusion
b91f3af
@PoisonPhang @aeryz
feat(ucs01-relay): error on no submsg
c58f919
@PoisonPhang @aeryz
fix(ucs01-relay): use proto struct when calling go
48b09af
@PoisonPhang @aeryz
fix(uniond): create diferred ack keeper correctly
2bff111
@PoisonPhang @aeryz
feat(ucs01-relay): correctly forward ack
373a498
@PoisonPhang @aeryz
chore: sqlx offline in devshell
f771d5b
@PoisonPhang @aeryz
feat(ucs01-relay): remove pfm store on ack
ebe81be
@PoisonPhang @aeryz
chore: nix fmt
01223e0
@PoisonPhang @aeryz
chore(uniond): diferredack -> deferredack
374f76e
@PoisonPhang @aeryz
chore: generate rust protos
8e4b71c
@PoisonPhang @aeryz
chore(ucs01-relay): diferred -> deferred
324031f
@PoisonPhang @aeryz
feat(uniond): added da cv to vm
01573c8
@PoisonPhang @aeryz
feat: added da key to storage upgrades
8d10452
@PoisonPhang @aeryz
feat(ucs01-relay): support memo extensions
95cc231
@PoisonPhang @aeryz
feat(ucs01-relay): support memo extension from sol
1031870
@PoisonPhang @aeryz
chore: generate rust sol bindings
7ffd2ba
@PoisonPhang @aeryz
feat(ucli): support memo when submitting eth txs
82d1332
@aeryz
chore(ucs01): handle memo for ucs01 transfer packet
7651186 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch 2 times, most recently from 83e398a to d4cd34c Compare June 5, 2024 17:59
@aeryz
chore: fmt
7347141 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz force-pushed the 1547-integrate-packet-forward-middleware-for-usc branch from d4cd34c to 7347141 Compare June 5, 2024 18:00
@aeryz aeryz merged commit 17f9053 into main Jun 6, 2024
79 checks passed
@aeryz aeryz deleted the 1547-integrate-packet-forward-middleware-for-usc branch June 6, 2024 07:12
@PoisonPhang PoisonPhang mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussein-aitlahcen hussein-aitlahcen hussein-aitlahcen left review comments

@benluelo benluelo benluelo left review comments

@aeryz aeryz aeryz approved these changes

Assignees

@PoisonPhang PoisonPhang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate packet-forward-middleware for USC
5 participants
@PoisonPhang @cor @hussein-aitlahcen @aeryz @benluelo