Typing/mypy settings #1911
Draft
Typing/mypy settings #1911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1911 +/- ##
===========================================
- Coverage 94.28% 65.00% -29.28%
===========================================
Files 91 121 +30
Lines 7013 9374 +2361
===========================================
- Hits 6612 6094 -518
- Misses 401 3280 +2879 ☔ View full report in Codecov by Sentry. |
m-richards
force-pushed
the
typing/mypy_settings
branch
from
a2e7015 to
bba5674
Compare
m-richards
force-pushed
the
typing/mypy_settings
branch
2 times, most recently
from
2acafb9 to
80bd6b8
Compare
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
…nai-oss#1905) Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * trial type annotations Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * changes in individual api files Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * pl.dataframe working in local test Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * older python union compat Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * try polars in the mypy env on ci Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * translate toplevel mypy skip into module specific skips Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * mypy passes Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * missing line continuation Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * python 3.8 Signed-off-by: Matt Richards <mrichards7@outlook.com.au> --------- Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
* declared support for python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * set python3.8 as min python in setup's 'python_requires' Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * bumped pylint to <3.3 (3.2.x latest to be run with 3.8) Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added pyupgrade and applied modifications Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github/tests: skipped pyspark tests on 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * TEMP: disabled pylint warnings (possibly-used-before-assignment). need addressing Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * .github: added setuptools to test run deps (required by noxfile), since it's no longer installed by default with python 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * added setuptools as an explicit test dependency it is required in noxfile and not automatically provided by python >= 3.12 Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated dependency spec of typing_extensions typing_extensions is currently required by all python versions Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> * updated autogen requirements files Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> --------- Signed-off-by: Guillaume Andreu Sabater <guillaume.andreu.sabater@gmail.com> Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
…nai-oss#1905) Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * trial type annotations Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * changes in individual api files Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * pl.dataframe working in local test Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * older python union compat Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * try polars in the mypy env on ci Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * translate toplevel mypy skip into module specific skips Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * mypy passes Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * missing line continuation Signed-off-by: Matt Richards <mrichards7@outlook.com.au> * python 3.8 Signed-off-by: Matt Richards <mrichards7@outlook.com.au> --------- Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
m-richards
force-pushed
the
typing/mypy_settings
branch
from
e959f37 to
8205e3d
Compare
Signed-off-by: Matt Richards <mrichards7@outlook.com.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting mypy changes to experiment with resolving mypy issues in #1905.
I've just initially pushed now with failing tests to show a point, but I'll probably drive discussion from the other PR for now.