[WIP] Implement more Ibis data types and built-in checks #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ibis-dev #1906 +/- ##
============================================
- Coverage 94.29% 92.97% -1.32%
============================================
Files 91 134 +43
Lines 7024 9768 +2744
============================================
+ Hits 6623 9082 +2459
- Misses 401 686 +285 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
|
|
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/ibis/more-builtin-checks
branch
from
9cdcae4 to
213ccae
Compare
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
deepyaman
force-pushed
the
feat/ibis/more-builtin-checks
branch
from
94739cd to
5352be0
Compare
deepyaman
changed the title
deepyaman
changed the title
|
Update: Currently struggling with getting timestamp tests to work, but I just discovered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved to draft, as I can just work off of this to add types and checks. Will probably rebase-merge instead of squash-merging, since I'll keep the commit history as clean as possible.