Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete invitation to org #749

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Conversation

SySagar
Copy link
Contributor

@SySagar SySagar commented Aug 27, 2024

What does this PR do?

Fixes #717

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

https://www.loom.com/share/8a297c486c814c3a8a8b756ba536168c?sid=8dffbe3b-ec70-417b-b599-a8986c2d0a23

Additonal note:

If you see the error toast that is becuse those two invites were cached during my testing of this query. So no worries there.

@BlankParticle
Copy link
Member

If the invite was accepted already, this would delete everything about the user. Please make sure that accepted invites can not be deleted. Only pending/expired invites can be deleted

Copy link
Member

Merge activity

  • Aug 28, 1:42 PM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@BlankParticle BlankParticle merged commit cf2fceb into un:main Aug 28, 2024
2 checks passed
BlankParticle added a commit that referenced this pull request Aug 28, 2024
* feat: delete invitation to org

* chore(org-invite): converted callback to functional component

* chore(org-invite): remove action button for used/accepted emails

* fix: don't allow deleting used invites on server

---------

Co-authored-by: BlankParticle <blankparticle@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENG-155] Fix: Allow deleting invitations
3 participants