Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: form schema for smtp port #742

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix: form schema for smtp port #742

merged 1 commit into from
Aug 26, 2024

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Aug 26, 2024 •
edited
Loading

What does this PR do?

Fix form schema to allow smtp port to be a number coerced from string.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

@BlankParticle Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle added priority these issues needs to prioritize before others bug Something isn't working labels Aug 26, 2024 — with Graphite App
@BlankParticle BlankParticle marked this pull request as ready for review August 26, 2024 08:10
@BlankParticle BlankParticle force-pushed the blank/fix/external-email-smtp-port branch from fdc6e6e to 91fef16 Compare August 26, 2024 08:17
@BlankParticle BlankParticle merged commit 120a09c into main Aug 26, 2024
5 checks passed
@BlankParticle Graphite App
Copy link
Member Author

Merge activity

@BlankParticle BlankParticle deleted the blank/fix/external-email-smtp-port branch August 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPizza0 McPizza0 McPizza0 approved these changes

Assignees

@BlankParticle BlankParticle

Labels
bug Something isn't working priority these issues needs to prioritize before others
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BlankParticle @McPizza0