feat: Handle errors in hono apps to prevent crashes (#473)

un · May 25, 2024 · 02bb84a · 02bb84a
1 parent 6f49ee9
commit 02bb84a
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 1 deletion.
diff --git a/apps/mail-bridge/app.ts b/apps/mail-bridge/app.ts
@@ -40,9 +40,32 @@ app.route('/postal', inboundApi);
 // 404 handler
 app.notFound((c) => c.json({ message: 'Not Found' }, 404));
 
+// Global error handler
+app.onError((err, c) => {
+  console.error(err);
+  return c.json({ message: 'Something went wrong' }, 500);
+});
+
+// Development error handlers
+if (env.NODE_ENV === 'development') {
+  process.on('unhandledRejection', (err) => {
+    console.error(err);
+  });
+  process.on('uncaughtException', (err) => {
+    console.error(err);
+  });
+}
+
+// Start server
 serve({
   fetch: app.fetch,
   port: env.PORT
 }).on('listening', () => {
   console.info(`Server listening on port ${env.PORT}`);
 });
+
+// Clean Exit
+process.on('exit', () => {
+  console.info('Shutting down...');
+  process.exit(0);
+});
diff --git a/apps/platform/app.ts b/apps/platform/app.ts
@@ -55,9 +55,32 @@ app.use(
 // 404 handler
 app.notFound((c) => c.json({ message: 'Not Found' }, 404));
 
+// Global error handler
+app.onError((err, c) => {
+  console.error(err);
+  return c.json({ message: 'Something went wrong' }, 500);
+});
+
+// Development error handlers
+if (env.NODE_ENV === 'development') {
+  process.on('unhandledRejection', (err) => {
+    console.error(err);
+  });
+  process.on('uncaughtException', (err) => {
+    console.error(err);
+  });
+}
+
+// Start server
 serve({
   fetch: app.fetch,
   port: env.PORT
 }).on('listening', () => {
   console.info(`Server listening on port ${env.PORT}`);
 });
+
+// Clean Exit
+process.on('exit', () => {
+  console.info('Shutting down...');
+  process.exit(0);
+});
diff --git a/apps/storage/app.ts b/apps/storage/app.ts
@@ -49,9 +49,32 @@ app.route('/api', deleteAttachmentsApi);
 // 404 handler
 app.notFound((c) => c.json({ message: 'Route Not Found' }, 404));
 
+// Global error handler
+app.onError((err, c) => {
+  console.error(err);
+  return c.json({ message: 'Something went wrong' }, 500);
+});
+
+// Development error handlers
+if (env.NODE_ENV === 'development') {
+  process.on('unhandledRejection', (err) => {
+    console.error(err);
+  });
+  process.on('uncaughtException', (err) => {
+    console.error(err);
+  });
+}
+
+// Start server
 serve({
   fetch: app.fetch,
   port: env.PORT
 }).on('listening', () => {
   console.info(`Server listening on port ${env.PORT}`);
 });
+
+// Clean Exit
+process.on('exit', () => {
+  console.info('Shutting down...');
+  process.exit(0);
+});
diff --git a/ee/apps/billing/app.ts b/ee/apps/billing/app.ts
@@ -11,6 +11,8 @@ import { db } from '@u22n/database';
 import { stripeData } from './stripe';
 import { validateLicense } from './validateLicenseKey';
 
+await validateLicense();
+
 const app = new Hono<Ctx>();
 
 // CORS middleware
@@ -48,11 +50,32 @@ app.use(
 // 404 handler
 app.notFound((c) => c.json({ message: 'Not Found' }, 404));
 
-await validateLicense();
+// Global error handler
+app.onError((err, c) => {
+  console.error(err);
+  return c.json({ message: 'Something went wrong' }, 500);
+});
 
+// Development error handlers
+if (env.NODE_ENV === 'development') {
+  process.on('unhandledRejection', (err) => {
+    console.error(err);
+  });
+  process.on('uncaughtException', (err) => {
+    console.error(err);
+  });
+}
+
+// Start server
 serve({
   fetch: app.fetch,
   port: env.PORT
 }).on('listening', () => {
   console.info(`Server listening on port ${env.PORT}`);
 });
+
+// Clean Exit
+process.on('exit', () => {
+  console.info('Shutting down...');
+  process.exit(0);
+});