Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support ESLint v9 #61

Closed
wants to merge 1 commit into from
Closed

Conversation

antfu
Copy link

@antfu antfu commented Mar 23, 2024

fix #60

As mentioned in #60, if we are able to upgrade @typescript-eslint/utils the types will be better and we won't need as any

Copy link

changeset-bot bot commented Mar 23, 2024

⚠️ No Changeset found

Latest commit: 3de85aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 80.55556% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 95.46%. Comparing base (e6774db) to head (3de85aa).

Files Patch % Lines
src/rules/no-mutable-exports.ts 66.66% 2 Missing ⚠️
src/rules/newline-after-import.ts 80.00% 1 Missing ⚠️
src/rules/no-amd.ts 75.00% 1 Missing ⚠️
src/rules/no-commonjs.ts 80.00% 1 Missing ⚠️
src/rules/no-namespace.ts 75.00% 1 Missing ⚠️
src/utils/declared-scope.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   96.48%   95.46%   -1.02%     
==========================================
  Files          90       90              
  Lines        4433     4454      +21     
  Branches     1560     1581      +21     
==========================================
- Hits         4277     4252      -25     
- Misses        150      192      +42     
- Partials        6       10       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin
Copy link
Member

JounQin commented Mar 23, 2024

https://github.com/ota-meshi/eslint-compat-utils can be used without breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESLint v9.0
2 participants