Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for using resolver object directly in settings #159

Merged
merged 7 commits into from
Sep 22, 2024

Conversation

GoodbyeNJN
Copy link

close #75

Copy link

changeset-bot bot commented Sep 11, 2024

🦋 Changeset detected

Latest commit: 2ab6a20

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Sep 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@GoodbyeNJN
Copy link
Author

@JounQin @SukkaW Sorry to bother you, but can anyone push this PR?
I proposed this feature before, but there was no discussion, so I decided to implement it first.
If you are free, could you review this feature proposal and code?

src/types.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.01%. Comparing base (8b53954) to head (2ab6a20).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
src/utils/resolve.ts 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #159      +/-   ##
==========================================
- Coverage   96.22%   96.01%   -0.21%     
==========================================
  Files          91      101      +10     
  Lines        4399     4670     +271     
  Branches     1497     1601     +104     
==========================================
+ Hits         4233     4484     +251     
- Misses        160      180      +20     
  Partials        6        6              
Flag Coverage Δ
96.01% <96.55%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SukkaW
Copy link
Collaborator

SukkaW commented Sep 21, 2024

@JounQin @SukkaW Sorry to bother you, but can anyone push this PR? I proposed this feature before, but there was no discussion, so I decided to implement it first. If you are free, could you review this feature proposal and code?

Sorry for the late reply. I like this change very much! I have added only a small review suggestion, and I have approved the CI to run. We can ship this as long as all existing test cases are passed.

Another thought, would you mind adding a test case for your change as well? So that we can test against the new config.

@GoodbyeNJN
Copy link
Author

Another thought, would you mind adding a test case for your change as well? So that we can test against the new config.

I have added test cases and reorganized the test set. Could you please approve running CI again?

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.changeset/red-rings-pay.md Outdated Show resolved Hide resolved
@SukkaW SukkaW merged commit 4da5388 into un-ts:master Sep 22, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Support using any object satisfied Resolver type in import-x/resolver options
2 participants