[osx] apply hid enviroment

umjammer · Jan 30, 2024 · 2d7a9ca · 2d7a9ca
1 parent 3aa9f07
commit 2d7a9ca
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 18 deletions.
diff --git a/plugins/OSX/src/main/java/net/java/games/input/osx/OSXEnvironmentPlugin.java b/plugins/OSX/src/main/java/net/java/games/input/osx/OSXEnvironmentPlugin.java
@@ -35,6 +35,7 @@
 
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.StringTokenizer;
 import java.util.logging.Level;
@@ -50,6 +51,7 @@
 import net.java.games.input.PollingController;
 import net.java.games.input.Rumbler;
 import net.java.games.input.usb.GenericDesktopUsageId;
+import net.java.games.input.usb.HidControllerEnvironment;
 import net.java.games.input.usb.UsagePage;
 import net.java.games.input.usb.UsagePair;
 
@@ -61,7 +63,7 @@
  * @author gregorypierce
  * @version 1.0
  */
-public final class OSXEnvironmentPlugin extends ControllerEnvironment {
+public final class OSXEnvironmentPlugin extends ControllerEnvironment implements HidControllerEnvironment {
 
     private static final Logger log = Logger.getLogger(OSXEnvironmentPlugin.class.getName());
 
@@ -256,4 +258,13 @@ private void enumerateControllers() {
             log.log(Level.FINE, "Failed to enumerate devices: " + e.getMessage(), e);
         }
     }
+
+    @Override
+    public OSXController getController(int mid, int pid) {
+        return Arrays.stream(getControllers())
+                .filter(c -> c instanceof OSXController)
+                .map(c -> (OSXController) c)
+                .filter(c -> c.getProductId() == pid && c.getVendorId() == mid)
+                .findFirst().get();
+    }
 }
diff --git a/plugins/OSX/src/main/java/net/java/games/input/osx/plugin/DualShock4Plugin.java b/plugins/OSX/src/main/java/net/java/games/input/osx/plugin/DualShock4Plugin.java
@@ -29,8 +29,6 @@
 /**
  * DualShock4Plugin.
  *
- * TODO extract osx independent part
- *
  * @author <a href="mailto:umjammer@gmail.com">Naohide Sano</a> (nsano)
  * @version 0.00 2023-10-24 nsano initial version <br>
  */

diff --git a/plugins/OSX/src/test/java/net/java/games/input/osx/OSXPluginTest.java b/plugins/OSX/src/test/java/net/java/games/input/osx/OSXPluginTest.java
@@ -59,9 +59,9 @@ void setup() throws Exception {
 
     @Test
     void test1() throws Exception {
-        OSXEnvironmentPlugin plugin = new OSXEnvironmentPlugin();
-Debug.println("getControllers: " + plugin.getControllers().length);
-        Arrays.stream(plugin.getControllers()).forEach(System.err::println);
+        OSXEnvironmentPlugin environment = new OSXEnvironmentPlugin();
+Debug.println("getControllers: " + environment.getControllers().length);
+        Arrays.stream(environment.getControllers()).forEach(System.err::println);
     }
 
     @Test
@@ -73,25 +73,17 @@ void test2() throws Exception {
     @EnabledIf("localPropertiesExists")
     @DisplayName("components count")
     void test3() throws Exception {
-        OSXEnvironmentPlugin plugin = new OSXEnvironmentPlugin();
-        OSXController controller = Arrays.stream(plugin.getControllers())
-                .filter(c -> c instanceof OSXController)
-                .map(c -> (OSXController) c)
-                .filter(c -> c.getProductId() == productId && c.getVendorId() == vendorId)
-                .findFirst().get();
+        OSXEnvironmentPlugin environment = new OSXEnvironmentPlugin();
+        OSXController controller = environment.getController(vendorId, productId);
         assertEquals(21, controller.getComponents().length);
     }
 
     @Test
     @EnabledIf("localPropertiesExists")
     @DisplayName("rumbler")
     void test4() throws Exception {
-        OSXEnvironmentPlugin plugin = new OSXEnvironmentPlugin();
-        OSXController controller = Arrays.stream(plugin.getControllers())
-                .filter(c -> c instanceof OSXController)
-                .map(c -> (OSXController) c)
-                .filter(c -> c.getProductId() == productId && c.getVendorId() == vendorId)
-                .findFirst().get();
+        OSXEnvironmentPlugin environment = new OSXEnvironmentPlugin();
+        OSXController controller = environment.getController(vendorId, productId);
 
         Report5 report = new Report5();
         report.smallRumble = 255;