Skip to content

Commit

Permalink
Merge pull request #2 from umjammer/0.0.2
Browse files Browse the repository at this point in the history
0.0.2
  • Loading branch information
umjammer authored Jan 2, 2025
2 parents 01a4168 + d265e01 commit 1afbc64
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
9 changes: 3 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
### 🐣️ this project is a good exsample of

* maven plugin
* maven plugin junit5 test
* ~~maven plugin junit5 test~~ wip

## Install

Expand Down Expand Up @@ -68,11 +68,7 @@ $ mvn -f src/test/resources/test-pom.xml validate
[INFO]
[INFO] --- careless:0.0.1-SNAPSHOT:careless (default) @ sample ---
[INFO] OK: yml: matched: for target: { path='.github/workflows/codeql.yml', ri='jobs.analyze.steps[2].name', value='Set up JDK 17' }
[INFO] OK: yml: matched: for target: { path='.github/workflows/codeql.yml', ri='jobs.analyze.steps[2].with.java-version', value='17' }
[INFO] OK: yml: matched: for target: { path='.github/workflows/maven.yml', ri='jobs.build.steps[2].name', value='Set up JDK 17' }
[INFO] OK: yml: matched: for target: { path='.github/workflows/maven.yml', ri='jobs.build.steps[2].with.java-version', value='17' }
[INFO] OK: xml: matched: for target: { path='pom.xml', ri='//*[local-name()='artifactId' and text()='maven-compiler-plugin']/..//*[local-name()='release' or local-name()='source']/text()', value='17' }
[INFO] OK: yml: matched: for target: { path='jitpack.yml', ri='jdk[0]', value='openjdk17' }
[INFO] OK: md: matched: for target: { path='README.md', ri='img\.shields\.io\/badge\/Java-(\d+?)-b07219', value='17' }, lines: [3]
[ERROR] NG: xml: matched: for target: { path='pom.xml', ri='//*[local-name()='project']/*[local-name()='version']/text()', value='.*-SNAPSHOT' }, actual: 0.0.1-SNAPSHOT
```
Expand All @@ -87,4 +83,5 @@ $ mvn -f src/test/resources/test-pom.xml validate
## TODO
* checkstyle
* checkstyle <- ???
* unit/integrated test
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>vavi</groupId>
<groupId>com.github.umjammer</groupId> <!-- plugins need the same group id? -->
<artifactId>careless-maven-plugin</artifactId>
<version>0.0.1</version>
<version>0.0.2</version>
<packaging>maven-plugin</packaging>

<build>
Expand Down

0 comments on commit 1afbc64

Please sign in to comment.