fix: SSR withoutHTML模式下，包一层<div id="root">{app}</div> #11724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
以解决 react-dom/server renderToReadableStream 不存在的问题
… Workers的平台" This reverts commit 5b0946a.
Co-authored-by: 咲奈Sakina <59400654+fz6m@users.noreply.github.com>
Co-authored-by: 咲奈Sakina <59400654+fz6m@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
sorrycc
approved these changes
Oct 11, 2023
fz6m
reviewed
Oct 11, 2023
| @@ -58,7 +58,7 @@ export async function getClientRootComponent(opts: { | |||
| </AppContext.Provider> | |||
| ); | |||
| if (opts.withoutHTML) { | |||
| return app; | |||
| return <div id="root">{app}</div>; | |||
There was a problem hiding this comment.
建议更新接口的声明以防止后续留坑和造成混淆，参考：
interface CreateServerlessOptions {
/** 注释 */
withoutHTML;
/** 注释 */
sourceDir;
}
interface CreateOptions extends CreateServerlessOptions {
// ...
}之所以这么做必要是因为这次两个新 option 大部分人都不需要，场景特定，所以应该尽可能的分而治之，防止后续在留坑。
fz6m
added a commit
to MoeYc/umi
that referenced
this pull request
Oct 23, 2023
fz6m
added a commit
that referenced
this pull request
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.