Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use define to inject SEARCH_WORKER_CODE instead of resourcequery dumi-raw #2161

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

Jinbao1001
Copy link
Member

@Jinbao1001 Jinbao1001 commented Jul 4, 2024

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

mako 不支持 resolve '-!xxx', 导致 ?dumi-raw 被 umi default loader 处理
这里将 workerjs 通过 define 注入, 兼容两种 bundler

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English searchworker?dumi-raw skip default loader
🇨🇳 Chinese searchworker?dumi-raw 跳过后续默认的 loader 处理

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2024 7:44am

@Jinbao1001 Jinbao1001 changed the title fix: searchworker?dumi-raw skip default loader fix: use define to inject WORKER_CODE instead of resourcequery dumi-raw Jul 4, 2024
@@ -35,6 +36,16 @@ export default (api: IApi) => {

if (cacheDirPath) _setFSCacheDir(path.join(cacheDirPath, 'dumi'));

Copy link
Member

@PeachScript PeachScript Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// inject raw code to use search worker in inline mode

'utf-8',
);
memo.define ??= {};
memo.define.WORKER_CODE = WORKER_CODE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议用 SEARCH_WORKER_CODE

@Jinbao1001 Jinbao1001 changed the title fix: use define to inject WORKER_CODE instead of resourcequery dumi-raw fix: use define to inject SEARCH_WORKER_CODE instead of resourcequery dumi-raw Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants