Bugfix: creating new doc type properties sort order doesn't count existing properties - puts it at top (+1) #2523
Conversation
umbraco/Umbraco-CMS#17457 Creating new doc type properties sort order doesn't count existing properties. Looking at this it seems that the hardwork is done to workout the sort order and assign it to preset but it's not returned undefined was (probably as a dev placeholder that's gone unnoticed!).
There was a problem hiding this comment.
Tested. Fixes the problem as described.
Thanks @cheeseytoastie!
leekelleher
changed the title
There was a problem hiding this comment.
@cheeseytoastie Thank you for the fix! 🚀
Thanks to @JasonElkin for testing, I've also verified the fix. Go team! 🙌
|
Hi there @cheeseytoastie! First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇 Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉 In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you! As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳 Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC. Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏 The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help! Kind regards, |
Description
Fixes umbraco/Umbraco-CMS#17457
Creating new doc type properties sort order doesn't count existing properties.
Looking at this it seems that the hardwork is done to workout the sort order and assign it to preset but it's not returned undefined was (probably as a dev placeholder that's gone unnoticed!).
Types of changes
How to test?
Checklist