Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: separate the build_test into two different jobs to save time #2079

Merged
merged 7 commits into from
Jul 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 16 additions & 19 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,23 +25,30 @@ env:
jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20]

steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: .nvmrc
cache: npm
cache-dependency-path: package-lock.json
cache-dependency-path: ./package-lock.json
- run: npm ci --no-audit --no-fund --prefer-offline
- run: npm run lint:errors
- run: npm run build
- run: npm run build:for:cms
- run: npm run generate:jsonschema:dist

test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version-file: .nvmrc
cache: npm
cache-dependency-path: ./package-lock.json
- run: npm ci --no-audit --no-fund --prefer-offline
- run: npx playwright install --with-deps
- run: npm test
- name: Upload Code Coverage reports
Expand All @@ -51,13 +58,3 @@ jobs:
name: code-coverage
path: coverage/
retention-days: 30
# Commented out since it is outdated and is quite spammy
# - name: Report code coverage
# uses: zgosalvez/github-actions-report-lcov@v2
# if: always()
# continue-on-error: true
# with:
# coverage-files: coverage/lcov.info
# artifact-name: code-coverage-report
# github-token: ${{ secrets.GITHUB_TOKEN }}
# working-directory: ./
2 changes: 1 addition & 1 deletion src/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const libraries = allowed.map((module) => {
preventAssignment: true,
values: {
'?inline': '',
}
},
}),
css({ minify: true }),
esbuild({ minify: true, sourceMap: true }),
Expand Down
Loading