Skip to content

Commit

Permalink
chore: remove alerts
Browse files Browse the repository at this point in the history
  • Loading branch information
iOvergaard committed May 23, 2024
1 parent e7665ce commit fb470a9
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export class UmbBlockTypeWorkspaceContext<BlockTypeData extends UmbBlockTypeWith
return 'block name content element type here...';
}
setName(name: string | undefined) {
alert('You cannot set a name of a block-type.');
console.warn('You cannot set a name of a block type.');
}

async propertyValueByAlias<ReturnType = unknown>(propertyAlias: string) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export class UmbPermissionsEntityAction extends UmbEntityActionBase<never> {
}

async execute() {
alert('Not implemented');
throw new Error('Method not implemented.');
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,7 @@ export class UmbMediaPickerCreateItemElement extends UmbLitElement {
this._allowedMediaTypes,
(item) => item.unique,
(item) =>
html`<uui-menu-item
label=${item.name}
@click=${() =>
alert(
'TODO: Open workspace (create) from modal. You can drop the files into this modal for now.',
)}>
html`<uui-menu-item label=${item.name}>
<umb-icon slot="icon" name=${item.icon ?? 'icon-circle-dotted'}></umb-icon>
</uui-menu-item>`,
)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,7 @@ export class UmbInputRichMediaElement extends UmbInputMediaElement {
<uui-card-media
name=${ifDefined(item.name === null ? undefined : item.name)}
detail=${ifDefined(item.unique)}
href="${this.editMediaPath}edit/${item.unique}"
@open=${() => {
alert('open media crops modal');
}}>
href="${this.editMediaPath}edit/${item.unique}">
${item.url
? html`<img src=${item.url} alt=${item.name} />`
: html`<umb-icon name=${ifDefined(item.mediaType.icon)}></umb-icon>`}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class UmbInstalledPackagesSectionViewItemElement extends UmbLitElement {
}

// TODO: add dedicated modal for package views, and register it in a manifest.
alert('package view modal temporarily disabled. See comment in code.');
throw new Error('package view modal temporarily disabled.');
/*
this._modalContext?.open(this, element, {
data: { name: this.name, version: this.version },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import { UmbEntityBulkActionBase } from '@umbraco-cms/backoffice/entity-bulk-act
export class UmbSetGroupUserEntityBulkAction extends UmbEntityBulkActionBase<object> {
async execute() {
//TODO: Implement
alert('Bulk set group is not implemented yet');
throw new Error('Bulk set group is not implemented yet');
}
}

0 comments on commit fb470a9

Please sign in to comment.