Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLS2-1277 Adding address to investment project requirements section #7570

Merged

Conversation

stuart-mindt
Copy link
Contributor

CLS2-1277 Adding address to investment project requirements section

Description of change

Ask to show the address fields on the investment project requirements section so that users do not need to click into the record to verify if the information has been added.

Test instructions

Tests will check that the new row renders showing the address information if present or will show 'not set'.

Screenshots

Before

Add a screenshot

After

image

Checklist

  • Has the branch been rebased to main?
  • Automated tests (Any of the following when applicable: Unit, Functional or End-to-End)
  • Manual compatibility testing (Browsers: Chrome, Firefox, Edge, Safari)

@stuart-mindt stuart-mindt requested a review from a team as a code owner February 19, 2025 15:55
Copy link

cypress bot commented Feb 19, 2025

data-hub-frontend    Run #59417

Run Properties:  status check passed Passed #59417  •  git commit de61b9b0d2: CLS2-1277 Adding address to investment project requirements section
Project data-hub-frontend
Branch Review feature/CLS2-1277_investment-project-show-address
Run status status check passed Passed #59417
Run duration 08m 14s
Commit git commit de61b9b0d2: CLS2-1277 Adding address to investment project requirements section
Committer Stuart Mindt
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 4
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 74
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (c8e97b6) to head (de61b9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7570   +/-   ##
=======================================
  Coverage   90.02%   90.03%           
=======================================
  Files        1122     1122           
  Lines       17442    17448    +6     
  Branches     5034     5040    +6     
=======================================
+ Hits        15703    15709    +6     
  Misses       1739     1739           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuart-mindt stuart-mindt merged commit 3e4cc60 into main Feb 20, 2025
16 checks passed
@stuart-mindt stuart-mindt deleted the feature/CLS2-1277_investment-project-show-address branch February 20, 2025 09:21
chopkinsmade pushed a commit that referenced this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants