Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated CLI and workflow #39

Merged
merged 23 commits into from
Jan 29, 2025
Merged

Add updated CLI and workflow #39

merged 23 commits into from
Jan 29, 2025

Conversation

samueljackson92
Copy link
Collaborator

@samueljackson92 samueljackson92 commented Dec 13, 2024

Cannot be merged before #35

Closes #37 #36

@samueljackson92 samueljackson92 added the enhancement New feature or request label Dec 13, 2024
@samueljackson92 samueljackson92 self-assigned this Dec 13, 2024
@samueljackson92 samueljackson92 linked an issue Dec 17, 2024 that may be closed by this pull request
@samueljackson92 samueljackson92 marked this pull request as ready for review December 17, 2024 09:32
@jameshod5
Copy link
Collaborator

There's a lot of changes but generally seems okay to me, do you have an example command that I can test?

@samueljackson92
Copy link
Collaborator Author

Sorry @jameshod5, I forgot to add that to the PR, and I think the README is updated in the next one.

I think something like:

python3 -m src.level1.main -v -n 1 --facility MAST --shot 28028 -i amc  

Should work. You will need a config.yml file which will look something like this:

metadatabase_file: /common/tmp/sjackson/level1.ukaea.db
readers:
  uda:
    type: 'uda'

writer:
  type: "zarr"
  options:
    zarr_format: 2
    output_path: "/common/tmp/sjackson/upload-tmp/zarr/level1"

Copy link
Collaborator

@jameshod5 jameshod5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Passed tests and works well for various shots/signals. Nothing sticks out to me

@samueljackson92 samueljackson92 merged commit c35c943 into main Jan 29, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants