-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add updated CLI and workflow #39
Conversation
There's a lot of changes but generally seems okay to me, do you have an example command that I can test? |
Sorry @jameshod5, I forgot to add that to the PR, and I think the README is updated in the next one. I think something like:
Should work. You will need a metadatabase_file: /common/tmp/sjackson/level1.ukaea.db
readers:
uda:
type: 'uda'
writer:
type: "zarr"
options:
zarr_format: 2
output_path: "/common/tmp/sjackson/upload-tmp/zarr/level1"
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Passed tests and works well for various shots/signals. Nothing sticks out to me
Cannot be merged before #35
Closes #37 #36