Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support VS code. #13

Open
jimiatworking opened this issue Feb 26, 2018 · 6 comments
Open

support VS code. #13

jimiatworking opened this issue Feb 26, 2018 · 6 comments

Comments

@jimiatworking
Copy link

Hi team, do you plan to use it on VS code?

@cschuff
Copy link
Member

cschuff commented Feb 26, 2018

Duplicate of #1

BR
Chris

@cschuff cschuff closed this as completed Feb 26, 2018
@cschuff
Copy link
Member

cschuff commented Feb 26, 2018

This could actually being solved using this vscode extension:
https://marketplace.visualstudio.com/items?itemName=IBM.XMLLanguageSupport#overview

I'll look into supporting this natively. Contributions welcome :) Working example repo would be helpful, too.

BR
Chris

@cschuff cschuff reopened this Feb 26, 2018
@cschuff
Copy link
Member

cschuff commented Feb 28, 2018

Here is a snippet for a .vscode/settings.json you could use for now:

{
  "xmlLang.javaHome": "C:\\Program Files\\Java\\jdk1.8.0_152",

  "xmlLang.xmlAssociations": [
    {
      "fileNamePattern": "**/*.+(view|fragment).xml",
      "systemId": "C:\\[USER_HOME]\\AppData\\Roaming\\UI5Experts\\ui5-schemas\\sapui5\\[VERSION]\\sap.ui.core.xsd" 
    },
    {
      "fileNamePattern": "**/*.+(view|fragment).xml",
      "systemId": "C:\\[USER_HOME]\\AppData\\Roaming\\UI5Experts\\ui5-schemas\\sapui5\\[VERSION]\\sap.ui.layout.xsd" 
    },
    {
      "fileNamePattern": "**/*.+(view|fragment).xml",
      "systemId": "C:\\[USER_HOME]\\AppData\\Roaming\\UI5Experts\\ui5-schemas\\sapui5\\[VERSION]\\sap.m.xsd" 
    }
  ]
}

@kozubikmichal
Copy link

Hi,

Were you able to get this running in VSCode?

Using this configuration I'm getting following error:
ct-props-correct.4: Error for type '_ViewType'. Duplicate attribute uses with the same name and target namespace are specified. Name of duplicate attribute use is 'controllerName'.

My configuration:

        "xmlLang.xmlAssociations": [{
		"fileNamePattern": "**/*.+(view|fragment).xml",
		"systemId": "xsd/sap.ui.core.xsd",
	}]

@cschuff
Copy link
Member

cschuff commented Jun 8, 2019

@kozubikmichal You could get rid of that by omiting the enhancement until #14 is fixed:
npx ui5-schemas --no-upgrade

@cschuff
Copy link
Member

cschuff commented Jun 9, 2019

@kozubikmichal #14 was just fixed with 0.4.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants