Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the IMS snow cover obs as an optional obs input. To use the IMS snow cover obs, a new subcomponent was added. This subcomponent built successfully on Hera (
/scratch1/NCEPDEV/stmp4/Edward.Snyder/IMS_snowcover_obs/git-repo/land-DA_workflow
), and from what I can tell, runs successfully.There are a number of changes that still need to be made in the
prep_obs
script, which are denoted by theTODO
tags. The main problem is that I cannot find observations to test these code changes. See below for a breakdown of this issue:Running the standard LND cold start case
/scratch1/NCEPDEV/stmp4/Edward.Snyder/IMS_snowcover_obs/git-repo/ims_case_data/ims2023121_4km_v1.3.nc
/scratch1/NCEPDEV/stmp4/Edward.Snyder/IMS_snowcover_obs/land-DA_update/jedi/restarts/20000104.000000.sfc_data.tile1.nc
/scratch1/NCEPDEV/stmp4/Edward.Snyder/IMS_snowcover_obs/git-repo/exp_case/00_96_lnd_coldstart
Running the standard LND cold start case with a newer date
clmforc.GSWP3*
)ufs_land_restart*
) - don't think this is neededOnce the obs issue is resolved and the Land DA system incorporates the IMS obs properly, then the
plot_stats
script will need to be updated to handle IMS snow cover obs.Anticipated changes to regression tests:
Subcomponents involved:
Linked PR's and Issues:
Testing (for CM's):