Skip using fluxes provided by land component for first time step #234
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,6 +10,7 @@ | |
| module sfc_land | ||
|
|
||
| use machine, only : kind_phys | ||
| use funcphys, only : fpvs | ||
|
|
||
| contains | ||
|
|
||
|
|
@@ -28,22 +29,41 @@ module sfc_land | |
| !! \section general General Algorithm | ||
| !! \section detailed Detailed Algorithm | ||
| !! @{ | ||
| subroutine sfc_land_run(im, flag_init, flag_restart, & | ||
| cpllnd, cpllnd2atm, flag_iter, dry, & | ||
| t1, q1, prsl1, prslki, ps, tskin, wind, cm, ch, rd, eps, epsm1, & | ||
| rvrdm1, hvap, cp, sncovr1_lnd, qsurf_lnd, & | ||
| evap_lnd, hflx_lnd, ep_lnd, t2mmp_lnd, q2mp_lnd, gflux_lnd, & | ||
| runoff_lnd, drain_lnd, cmm_lnd, chh_lnd, zvfun_lnd, & | ||
| sncovr1, qsurf, evap, hflx, ep, t2mmp, q2mp, & | ||
| gflux, runoff, drain, cmm, chh, zvfun, & | ||
| errmsg, errflg, naux2d, aux2d) | ||
|
|
||
| implicit none | ||
|
|
||
| ! Inputs | ||
| integer , intent(in) :: im | ||
| logical , intent(in) :: flag_init | ||
| logical , intent(in) :: flag_restart | ||
| logical , intent(in) :: cpllnd | ||
| logical , intent(in) :: cpllnd2atm | ||
| logical , intent(in) :: flag_iter(:) | ||
| logical , intent(in) :: dry(:) | ||
| real(kind=kind_phys), intent(in) :: t1(:) | ||
| real(kind=kind_phys), intent(in) :: q1(:) | ||
| real(kind=kind_phys), intent(in) :: prsl1(:) | ||
| real(kind=kind_phys), intent(in) :: prslki(:) | ||
| real(kind=kind_phys), intent(in) :: ps(:) | ||
| real(kind=kind_phys), intent(in) :: tskin(:) | ||
| real(kind=kind_phys), intent(in) :: wind(:) | ||
| real(kind=kind_phys), intent(in) :: cm(:) | ||
| real(kind=kind_phys), intent(in) :: ch(:) | ||
| real(kind=kind_phys), intent(in) :: rd | ||
| real(kind=kind_phys), intent(in) :: eps | ||
| real(kind=kind_phys), intent(in) :: epsm1 | ||
| real(kind=kind_phys), intent(in) :: rvrdm1 | ||
| real(kind=kind_phys), intent(in) :: hvap | ||
| real(kind=kind_phys), intent(in) :: cp | ||
| real(kind=kind_phys), intent(in), optional :: sncovr1_lnd(:) | ||
| real(kind=kind_phys), intent(in), optional :: qsurf_lnd(:) | ||
| real(kind=kind_phys), intent(in), optional :: evap_lnd(:) | ||
|
|
@@ -75,32 +95,76 @@ subroutine sfc_land_run(im, cpllnd, cpllnd2atm, flag_iter, dry, & | |
| character(len=*) , intent(out) :: errmsg | ||
| integer , intent(out) :: errflg | ||
|
|
||
| ! Constant parameters | ||
| real(kind=kind_phys), parameter :: & | ||
| & one = 1.0_kind_phys, & | ||
| & zero = 0.0_kind_phys, & | ||
| & qmin = 1.0e-8_kind_phys | ||
|
|
||
| ! Locals | ||
| integer :: i | ||
| real(kind=kind_phys) :: qss, rch, tem, cpinv, hvapi, elocp | ||
| real(kind=kind_phys), dimension(im) :: rho, q0 | ||
|
|
||
| ! Initialize CCPP error handling variables | ||
| errmsg = '' | ||
| errflg = 0 | ||
|
|
||
| cpinv = one/cp | ||
| hvapi = one/hvap | ||
| elocp = hvap/cp | ||
|
|
||
| ! Check coupling from component land to atmosphere | ||
| if (.not. cpllnd2atm) return | ||
|
|
||
| ! Check if it is cold or warm run | ||
| if (flag_init .and. .not. flag_restart) then | ||
|
There was a problem hiding this comment. @barlage I add this part to calculate land fluxes in the first time step. Let me know if you see any issue with it. There was a problem hiding this comment. @barlage The part that calculated land fluxes internally is producing very large values for latent and sensible heat flux. I am trying to debug it but it might be related to the way of calculation of qss (not sure now). Since this is based on sfc_ocean it might need to have some adjustment. Any suggestion? There was a problem hiding this comment. @uturuncoglu I was hoping we could get away with this simple approximation but perhaps there needs to be a constraint added based on available energy. Typically when this approach is used in the land model, there is an adjustment to qss for stomatal and soil evap resistance. What is being done here is essentially like a ponded surface, but I wouldn't think that would produce unreasonable values (though this could be happening over hot soils where the qss could get very large). In the land model, LH and SH are constrained by available energy, which we don't have here (neither does sfc_ocean), also we are considering them here to be independent, which they also aren't in the land model. But again, none of this should produce "very large" values, unless there is an initialization issue with some of the inputs. There was a problem hiding this comment. @barlage it seems that There was a problem hiding this comment. @uturuncoglu the qss coming from the function is vapor pressure in Pascals so 1400 is not unreasonable, it's the equivalent of about 0.009 kg/kg specific humidity There was a problem hiding this comment. If you are saying both fluxes are large, then I'm wondering if it's something with the input |
||
| ! Calculate fluxes internally | ||
| do i = 1, im | ||
| if (dry(i)) then | ||
| q0(i) = max(q1(i), qmin) | ||
| rho(i) = prsl1(i)/(rd*t1(i)*(one+rvrdm1*q0(i))) | ||
| qss = fpvs(tskin(i)) | ||
| qss = eps*qss/(ps(i)+epsm1*qss) | ||
| rch = rho(i)*cp*ch(i)*wind(i) | ||
| tem = ch(i)*wind(i) | ||
| sncovr1(i) = zero | ||
| qsurf(i) = qss | ||
| hflx(i) = rch*(tskin(i)-t1(i)*prslki(i)) | ||
| hflx(i) = hflx(i)*(1.0/rho(i))*cpinv | ||
| evap(i) = elocp*rch*(qss-q0(i)) | ||
| ep(i) = evap(i) | ||
| evap(i) = evap(i)*(1.0/rho(i))*hvapi | ||
| t2mmp(i) = tskin(i) | ||
| q2mp(i) = qsurf(i) | ||
| gflux(i) = zero | ||
| drain(i) = zero | ||
| runoff(i) = zero | ||
| cmm(i) = cm(i)*wind(i) | ||
| chh(i) = rho(i)*tem | ||
| zvfun(i) = one | ||
| end if | ||
| enddo | ||
| else | ||
| ! Use fluxes from land component model | ||
| do i = 1, im | ||
| if (dry(i)) then | ||
| sncovr1(i) = sncovr1_lnd(i) | ||
| qsurf(i) = qsurf_lnd(i) | ||
| hflx(i) = hflx_lnd(i) | ||
| evap(i) = evap_lnd(i) | ||
| ep(i) = ep_lnd(i) | ||
| t2mmp(i) = t2mmp_lnd(i) | ||
| q2mp(i) = q2mp_lnd(i) | ||
| gflux(i) = gflux_lnd(i) | ||
| drain(i) = drain_lnd(i) | ||
| runoff(i) = runoff_lnd(i) | ||
| cmm(i) = cmm_lnd(i) | ||
| chh(i) = chh_lnd(i) | ||
| zvfun(i) = zvfun_lnd(i) | ||
| end if | ||
| enddo | ||
| endif | ||
|
|
||
| end subroutine sfc_land_run | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uturuncoglu I'm a little confused at the logic now. I thought with the new approach that we wouldn't need to call ccpp noahmp at all. Isn't this saying that with the land component, on the first time step we need to run the ccpp noahmp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barlage let me check this part again. I might need to remove
(.not. flag_init)since I think it is not neccecary. The logic is that the sfc_land will calculate the fluxes internally in the initial step (if it is cold run) and after that will get the fluxes from component model.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that was my main point, that the changes to noahmpdrv.F90 and .meta don't seem necessary anymore.