Fix deprecated vacuum states in vacuum entity #244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing error: 2025-01-14 19:52:56.113 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_CLEANING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.CLEANING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.128 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_DOCKED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.DOCKED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.139 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_PAUSED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.PAUSED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.155 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_IDLE was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.IDLE instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.168 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_RETURNING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.RETURNING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.183 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_ERROR was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.ERROR instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.193 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_CLEANING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.CLEANING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.205 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_DOCKED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.DOCKED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.215 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_PAUSED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.PAUSED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.225 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_IDLE was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.IDLE instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.238 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_RETURNING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.RETURNING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.248 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_ERROR was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.ERROR instead, please report it to the author of the 'zcsmower' custom integration
ufozone
reviewed
Jan 14, 2025
ufozone
changed the title
|
I also fixed the state names... sorry but I didn't test the fix before pushing :) With the latest PR I sent it should be ok |
ufozone
reviewed
Jan 14, 2025
| @@ -24,8 +19,8 @@ | |||
| LOGGER, | |||
| DOMAIN, | |||
| ) | |||
| from .coordinator import ZcsMowerDataUpdateCoordinator | |||
| from .entity import ZcsMowerRobotEntity | |||
| from .coordinator import ZcsDataUpdateCoordinator | |||
There was a problem hiding this comment.
Suggested change
| from .coordinator import ZcsDataUpdateCoordinator | |
| from .coordinator import ZcsMowerDataUpdateCoordinator |
ufozone
reviewed
Jan 14, 2025
| from .coordinator import ZcsMowerDataUpdateCoordinator | ||
| from .entity import ZcsMowerRobotEntity | ||
| from .coordinator import ZcsDataUpdateCoordinator | ||
| from .entity import ZcsMowerEntity |
There was a problem hiding this comment.
Suggested change
| from .entity import ZcsMowerEntity | |
| from .entity import ZcsMowerRobotEntity |
ufozone
reviewed
Jan 14, 2025
| @@ -37,7 +32,7 @@ | |||
| | VacuumEntityFeature.START | |||
| | VacuumEntityFeature.MAP | |||
| ) | |||
| ROBOT_ENTITY_DESCRIPTIONS = ( | |||
| ENTITY_DESCRIPTIONS = ( | |||
There was a problem hiding this comment.
Suggested change
| ENTITY_DESCRIPTIONS = ( | |
| ROBOT_ENTITY_DESCRIPTIONS = ( |
ufozone
reviewed
Jan 14, 2025
| @@ -55,21 +50,21 @@ async def async_setup_entry( | |||
| coordinator = config_entry.runtime_data | |||
| async_add_entities( | |||
| [ | |||
| ZcsMowerRobotVacuumEntity( | |||
| ZcsMowerVacuumEntity( | |||
There was a problem hiding this comment.
Suggested change
| ZcsMowerVacuumEntity( | |
| ZcsMowerRobotVacuumEntity( |
ufozone
reviewed
Jan 14, 2025
| hass=hass, | ||
| config_entry=config_entry, | ||
| coordinator=coordinator, | ||
| entity_description=entity_description, | ||
| imei=imei, | ||
| ) | ||
| for imei in coordinator.mowers | ||
| for entity_description in ROBOT_ENTITY_DESCRIPTIONS | ||
| for entity_description in ENTITY_DESCRIPTIONS |
There was a problem hiding this comment.
Suggested change
| for entity_description in ENTITY_DESCRIPTIONS | |
| for entity_description in ROBOT_ENTITY_DESCRIPTIONS |
ufozone
reviewed
Jan 14, 2025
| ], | ||
| update_before_add=True, | ||
| ) | ||
|
|
||
|
|
||
| class ZcsMowerRobotVacuumEntity(ZcsMowerRobotEntity, StateVacuumEntity): | ||
| class ZcsMowerVacuumEntity(ZcsMowerEntity, StateVacuumEntity): |
There was a problem hiding this comment.
Suggested change
| class ZcsMowerVacuumEntity(ZcsMowerEntity, StateVacuumEntity): | |
| ZcsMowerRobotVacuumEntity(ZcsMowerRobotEntity, StateVacuumEntity): |
ufozone
reviewed
Jan 14, 2025
| @@ -79,7 +74,7 @@ def __init__( | |||
| self, | |||
| hass: HomeAssistant, | |||
| config_entry: ConfigEntry, | |||
| coordinator: ZcsMowerDataUpdateCoordinator, | |||
| coordinator: ZcsDataUpdateCoordinator, | |||
There was a problem hiding this comment.
Suggested change
| coordinator: ZcsDataUpdateCoordinator, | |
| coordinator: ZcsMowerDataUpdateCoordinator, |
|
You seem to have used an older version of vacuum.py for your fix. Please merge your fix with the file from the main branch. |
|
I forked the main branch and then apply the fix. What shall I do now? Create a new PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing error:
2025-01-14 19:52:56.113 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_CLEANING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.CLEANING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.128 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_DOCKED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.DOCKED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.139 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_PAUSED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.PAUSED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.155 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_IDLE was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.IDLE instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.168 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_RETURNING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.RETURNING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.183 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_ERROR was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.ERROR instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.193 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_CLEANING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.CLEANING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.205 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_DOCKED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.DOCKED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.215 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_PAUSED was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.PAUSED instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.225 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_IDLE was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.IDLE instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.238 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_RETURNING was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.RETURNING instead, please report it to the author of the 'zcsmower' custom integration 2025-01-14 19:52:56.248 WARNING (ImportExecutor_0) [homeassistant.components.vacuum] STATE_ERROR was used from zcsmower, this is a deprecated constant which will be removed in HA Core 2026.1. Use VacuumActivity.ERROR instead, please report it to the author of the 'zcsmower' custom integration