Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to function validate teachers #112

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

KleversonNascimento
Copy link
Contributor

Change Request

Description

Adds new tests to ensure it works

How do I test this?

run yarn test

Checklist

  • I have performed a self-review of my own code;
  • I have added tests that prove my fix is effective or that my feature works;

JhonataSantana and others added 16 commits November 19, 2021 17:55
@KleversonNascimento KleversonNascimento changed the title Sprint 4 Add unit test to function validate teachers Dec 8, 2021
describe('teachers', function () {
it('should return empty list when has not errors', function () {
const disciplinas = [
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 6 spaces but found 8.

Suggested change
{
{

{
teoria: {
name: 'Vanessa Kruth',
error: null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.

Suggested change
error: null,
error: null,

name: 'Vanessa Kruth',
error: null,
},
pratica: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.

Suggested change
pratica: {
pratica: {

const disciplinas = [
{
teoria: {
name: 'Vanessa Kruth',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.

Suggested change
name: 'Vanessa Kruth',
name: 'Vanessa Kruth',

it('should return empty list when has not errors', function () {
const disciplinas = [
{
teoria: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.

Suggested change
teoria: {
teoria: {

},
{
teoria: {
name: 'Isidro',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.

Suggested change
name: 'Isidro',
name: 'Isidro',

{
teoria: {
name: 'Isidro',
error: 'Sala não encontrada',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.

Suggested change
error: 'Sala não encontrada',
error: 'Sala não encontrada',

teoria: {
name: 'Vanessa Kruth',
error: null,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.

Suggested change
},
},

pratica: {
name: 'Vanessa Kruth',
error: null,
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.

Suggested change
}
}

error: null,
}
},
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codacy has a fix for the issue: Extra semicolon.

Suggested change
];
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants