Unit tests CI + Lint CI + Coefficients calc unit tests #103
Conversation
| 'BHQ0001-15', // IDENT.E CULTURA | ||
| ] | ||
| const date = new Date("2021-04-01") | ||
| const func = findIdeais(date) |
There was a problem hiding this comment.
@hadeoliveira tive que excluir aqui porque func não estava sendo usada e isso dá erro no lint, na verdade o problema é que esse teste não tava testando a função de verdade, só estava comparando o array expectedCourses com ele mesmo, você pode corrigir?
There was a problem hiding this comment.
Correção efetuada e submetida no PR #104
KleversonNascimento
changed the title
Agora o comando "Coverage" está funcional e o report é registrado no arquivo "coverage.lcov", deixando a função de análise dos resultados, para a geração de badge ou outras finalidades, de forma independente por meio de outros comandos, como o utilizado no CI em conjunto com o Codecov.
KleversonNascimento
force-pushed
the
add-some-tests
branch
from
bb4bb8c to
9e3b49d
Compare
KleversonNascimento
force-pushed
the
add-some-tests
branch
from
cfb5f4a to
24a3cdc
Compare
KleversonNascimento
force-pushed
the
add-some-tests
branch
from
24a3cdc to
359b5bc
Compare
| teoria: { | ||
| name: 'Vanessa Kruth', | ||
| error: null, | ||
| }, |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.
| }, | |
| }, |
| { | ||
| teoria: { | ||
| name: 'Isidro', | ||
| error: 'Sala não encontrada', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.
| error: 'Sala não encontrada', | |
| error: 'Sala não encontrada', |
| it('should return empty list when has not errors', function () { | ||
| const disciplinas = [ | ||
| { | ||
| teoria: { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.
| teoria: { | |
| teoria: { |
| name: 'Vanessa Kruth', | ||
| error: null, | ||
| }, | ||
| pratica: { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.
| pratica: { | |
| pratica: { |
| describe('teachers', function () { | ||
| it('should return empty list when has not errors', function () { | ||
| const disciplinas = [ | ||
| { |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 6 spaces but found 8.
| { | |
| { |
| }, | ||
| { | ||
| teoria: { | ||
| name: 'Isidro', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.
| name: 'Isidro', | |
| name: 'Isidro', |
| error: null, | ||
| } | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
Codacy has a fix for the issue: Extra semicolon.
| ]; | |
| ] |
| pratica: { | ||
| name: 'Vanessa Kruth', | ||
| error: null, | ||
| } |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 8 spaces but found 12.
| } | |
| } |
| { | ||
| teoria: { | ||
| name: 'Vanessa Kruth', | ||
| error: null, |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.
| error: null, | |
| error: null, |
| const disciplinas = [ | ||
| { | ||
| teoria: { | ||
| name: 'Vanessa Kruth', |
There was a problem hiding this comment.
Codacy has a fix for the issue: Expected indentation of 10 spaces but found 16.
| name: 'Vanessa Kruth', | |
| name: 'Vanessa Kruth', |
Change Request
Description
This PR is a combination of:
Add CI to run unit tests: UFABCNextOps#6
Add lint to CI: UFABCNextOps#7
Add unit tests to coefficients calc: https://github.com/ufabc-next/ufabc-next-server/blob/bb4bb8cafc1ce4bc1280f3cd88a5b7782a50ee45/app/helpers/calculate/coefficients.spec.js