Skip to content

Commit

Permalink
Fix version references and ignore .deno.lock.poll file (#101)
Browse files Browse the repository at this point in the history
  • Loading branch information
KyleJune authored Aug 31, 2024
1 parent 9f35340 commit 7d7592c
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 10 deletions.
2 changes: 1 addition & 1 deletion build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* ```jsonc
* "tasks": {
* // Builds the application.
* "build": "deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.22/build",
* "build": "deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.24.1/build",
* // Builds the application in development mode.
* "build-dev": "export APP_ENV=development NODE_ENV=development && deno task build",
* // Builds the application in production mode.
Expand Down
2 changes: 1 addition & 1 deletion deno.jsonc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@udibo/react-app",
"version": "0.24.0",
"version": "0.24.1",
"exports": {
".": "./mod.tsx",
"./build": "./build.ts",
Expand Down
5 changes: 3 additions & 2 deletions dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* ```jsonc
* "tasks": {
// Builds and runs the application in development mode, with hot reloading.
* "dev": "export APP_ENV=development NODE_ENV=development && deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.22/dev",
* "dev": "export APP_ENV=development NODE_ENV=development && deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.24.1/dev",
* }
* ```
*
Expand Down Expand Up @@ -270,7 +270,8 @@ export function startDev(options: DevOptions = {}): void {
artifacts.add(path.resolve(routesUrl, "./_main.ts"));

function isBuildArtifact(pathname: string) {
return pathname.startsWith(buildDir) || artifacts.has(pathname);
return pathname.startsWith(buildDir) || artifacts.has(pathname) ||
pathname.endsWith("/node_modules/.deno/.deno.lock.poll");
}

const shouldBuild = isCustomBuildArtifact
Expand Down
4 changes: 3 additions & 1 deletion docs/configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ To learn more about using the default tasks, see the

If you need to customize your build options to be different from the default,
follow the instructions for adding the [build.ts](getting-started.md#buildts)
and [dev.ts](getting-started.md#devts) files in the getting started guide.
and [dev.ts](getting-started.md#devts) files in the getting started guide. Then
for more information on the build configuration options available, see the
[build](#build) section of this guide.

You can add any tasks that you want to your configuration, for more information
on how to do so, see Deno's
Expand Down
10 changes: 5 additions & 5 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,13 @@ Node.js-like environment.
{
"tasks": {
// Builds the application.
"build": "deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.24/build",
"build": "deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.24.1/build",
// Builds the application in development mode.
"build-dev": "export APP_ENV=development NODE_ENV=development && deno task build",
// Builds the application in production mode.
"build-prod": "export APP_ENV=production NODE_ENV=production && deno task build",
// Builds and runs the application in development mode, with hot reloading.
"dev": "export APP_ENV=development NODE_ENV=development && deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.24/dev",
"dev": "export APP_ENV=development NODE_ENV=development && deno run -A --config=deno.jsonc jsr:@udibo/react-app@0.24.1/dev",
// Runs the application. Requires the application to be built first.
"run": "deno run -A ./main.ts",
// Runs the application in development mode. Requires the application to be built first.
Expand Down Expand Up @@ -141,7 +141,7 @@ Node.js-like environment.
"imports": {
"/": "./",
"./": "./",
"@udibo/react-app": "jsr:@udibo/react-app@0.22",
"@udibo/react-app": "jsr:@udibo/react-app@0.24.1",
"@std/assert": "jsr:@std/assert@1",
"@std/log": "jsr:@std/log@0",
"@std/path": "jsr:@std/path@1",
Expand Down Expand Up @@ -549,13 +549,13 @@ on:
jobs:
ci:
name: CI
uses: udibo/react-app/.github/workflows/ci.yml@0.24.0
uses: udibo/react-app/.github/workflows/ci.yml@0.24.1
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
cd:
name: CD
needs: ci
uses: udibo/react-app/.github/workflows/deploy.yml@0.24.0
uses: udibo/react-app/.github/workflows/deploy.yml@0.24.1
with:
project: udibo-react-app-example
```
Expand Down

0 comments on commit 7d7592c

Please sign in to comment.