Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Variant Peptide ID #877

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Fix Variant Peptide ID #877

merged 3 commits into from
Jun 24, 2024

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Jun 23, 2024

Description

VariantPeptideIdentifier.parse_variant_peptide_id parses variant peptide IDs, but when it converts back to str, ORF ID was placed in the wrong position. For example, ENST0001|SNV-100-A-T|ORF1|1 becomes ENST0001|ORF1|SNV-100-A-T|1. This makes annotator confused.

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn merged commit 2194fb6 into main Jun 24, 2024
6 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-split-fasta branch June 24, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant