Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix The Usage Section in Docs #837

Merged
merged 38 commits into from
Feb 2, 2024
Merged

Fix The Usage Section in Docs #837

merged 38 commits into from
Feb 2, 2024

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Jan 30, 2024

Description

The usage section in docs has mkdocs instead of moPepGen (see below). Fixed it to show the correct command name.

image

Also fixed grammar issues in documentations.

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn requested a review from lydiayliu January 30, 2024 07:01
@zhuchcn zhuchcn marked this pull request as ready for review January 30, 2024 17:26
@zhuchcn
Copy link
Member Author

zhuchcn commented Jan 30, 2024

@nwiltsie Hi Nick, help is needed! I just updated the cicd docker image from docker hub to ghcr. Didn't realize this until today. Why is my .pylintrc config file not recognized? I specifically disabled some warnings but they are still raised by pylint.

Copy link
Collaborator

@lydiayliu lydiayliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is taking some time to review, I'll keep at it!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/call-alt-translation.md Outdated Show resolved Hide resolved
docs/call-alt-translation.md Outdated Show resolved Hide resolved
docs/call-alt-translation.md Outdated Show resolved Hide resolved
docs/file-format.md Outdated Show resolved Hide resolved
docs/file-format.md Outdated Show resolved Hide resolved
@nwiltsie
Copy link
Member

Your .pylintrc file is being recognized - your changes in cec7b27 reduced the warnings from 28 to 12.

We updated the version of pylint when we migrated from the old container registry and I think there are a few new checks in there.

zhuchcn and others added 4 commits January 30, 2024 10:11
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
docs/split-fasta.md Outdated Show resolved Hide resolved
docs/split-fasta.md Outdated Show resolved Hide resolved
docs/split-fasta.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
zhuchcn and others added 2 commits January 30, 2024 10:13
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
.pylintrc Outdated Show resolved Hide resolved
@zhuchcn
Copy link
Member Author

zhuchcn commented Jan 30, 2024

Thanks Nick! I think when I clicked on the github action output link, it redirected me to an old run which has all the error messages that are supposed to be fixed. It's probably just GitHub being laggy. So now I only have the Cyclic import left. The old pylint doesn't complain about it. Should we just disable it, too? If there is a cyclic import, the problem won't run anyway, right?

@nwiltsie
Copy link
Member

You can also test the CICD process locally with the bllint script (https://github.com/uclahs-cds/docker-CICD-base?tab=readme-ov-file#how-to-run-locally). In order for that to work you'll need to make a .cicd-env file (you can literally duplicate this PR, it had the same change).

zhuchcn and others added 4 commits January 30, 2024 10:30
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
@nwiltsie
Copy link
Member

So now I only have the Cyclic import left. The old pylint doesn't complain about it. Should we just disable it, too? If there is a cyclic import, the problem won't run anyway, right?

I don't think it's a good idea to blindly disable, but fixing that code is out-of-scope for this PR. I'd recommend disabling it now but adding an issue (linking back here) to re-enable that check and fix the offending code.

@zhuchcn zhuchcn mentioned this pull request Jan 30, 2024
@zhuchcn
Copy link
Member Author

zhuchcn commented Jan 30, 2024

It's a lot of work to fix them all. But since the program is running, and the tests are all passed, would you say it's a relatively small issue for now?

Also, do you know why they were not caught by the old pylint?

zhuchcn and others added 3 commits January 30, 2024 11:00
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
zhuchcn and others added 2 commits January 30, 2024 11:01
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
@nwiltsie
Copy link
Member

For the purposes of this PR, things are golden! I don't know enough about the code in question to prioritize the new issue relative to other work, so I don't want to call it a "small issue", but at the very least the code is in the same state it was yesterday.

The old pylint didn't catch these circular imports because we were previously linting each file individually, but now we are linting them all simultaneously. That's also why the duplicate code checker is triggering - it could never see both files at once before.

docs/file-format.md Outdated Show resolved Hide resolved
docs/file-format.md Outdated Show resolved Hide resolved
docs/file-format.md Outdated Show resolved Hide resolved
docs/file-format.md Outdated Show resolved Hide resolved
docs/file-format.md Show resolved Hide resolved
docs/vignette.md Outdated Show resolved Hide resolved
docs/vignette.md Outdated Show resolved Hide resolved
docs/vignette.md Outdated Show resolved Hide resolved
docs/vignette.md Outdated Show resolved Hide resolved
docs/vignette.md Outdated Show resolved Hide resolved
zhuchcn and others added 18 commits February 2, 2024 09:59
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
@zhuchcn
Copy link
Member Author

zhuchcn commented Feb 2, 2024

I think I incorporated all your suggested changes. I also updated the repo name in all occurrences. @lydiayliu

@lydiayliu
Copy link
Collaborator

I don't want to go through this again XD just merge

@zhuchcn zhuchcn merged commit 504d949 into main Feb 2, 2024
2 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-docs branch February 2, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants