-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix The Usage Section in Docs #837
Conversation
@nwiltsie Hi Nick, help is needed! I just updated the cicd docker image from docker hub to ghcr. Didn't realize this until today. Why is my .pylintrc config file not recognized? I specifically disabled some warnings but they are still raised by pylint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taking some time to review, I'll keep at it!
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Thanks Nick! I think when I clicked on the github action output link, it redirected me to an old run which has all the error messages that are supposed to be fixed. It's probably just GitHub being laggy. So now I only have the Cyclic import left. The old pylint doesn't complain about it. Should we just disable it, too? If there is a cyclic import, the problem won't run anyway, right? |
You can also test the CICD process locally with the |
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
I don't think it's a good idea to blindly disable, but fixing that code is out-of-scope for this PR. I'd recommend disabling it now but adding an issue (linking back here) to re-enable that check and fix the offending code. |
It's a lot of work to fix them all. But since the program is running, and the tests are all passed, would you say it's a relatively small issue for now? Also, do you know why they were not caught by the old pylint? |
…n into czhu-fix-docs
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
For the purposes of this PR, things are golden! I don't know enough about the code in question to prioritize the new issue relative to other work, so I don't want to call it a "small issue", but at the very least the code is in the same state it was yesterday. The old pylint didn't catch these circular imports because we were previously linting each file individually, but now we are linting them all simultaneously. That's also why the duplicate code checker is triggering - it could never see both files at once before. |
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
Co-authored-by: Lydia Y. Liu <10492815+lydiayliu@users.noreply.github.com>
I think I incorporated all your suggested changes. I also updated the repo name in all occurrences. @lydiayliu |
I don't want to go through this again XD just merge |
Description
The usage section in docs has
mkdocs
instead ofmoPepGen
(see below). Fixed it to show the correct command name.Also fixed grammar issues in documentations.
Closes #...
Checklist
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.CHANGELOG.md
under the next release version or unreleased, and updated the date.