Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czhu fix summarize fasta #832

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Czhu fix summarize fasta #832

merged 4 commits into from
Jan 1, 2024

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Dec 14, 2023

Description

--variant-peptides is made optional now.

Closes #482

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn marked this pull request as ready for review December 14, 2023 22:48
@zhuchcn zhuchcn requested a review from lydiayliu December 14, 2023 22:49
@lydiayliu
Copy link
Collaborator

Can you also address the same thing for splitFasta in this PR? #482 (comment)

@lydiayliu
Copy link
Collaborator

@zhuchcn sorry what is the status on this XD (not that I need it now but just saw this PR again lol

@zhuchcn
Copy link
Member Author

zhuchcn commented Jan 1, 2024

Just fixed that!

Copy link
Collaborator

@lydiayliu lydiayliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, if I don't provide --variant-peptides I also don't have to provide --gvfs?

@zhuchcn
Copy link
Member Author

zhuchcn commented Jan 1, 2024

That's correct. Just like the test case I added, --gvf is not required if --variant-peptide is not provided.

@zhuchcn zhuchcn merged commit ebe509c into main Jan 1, 2024
2 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-summarize-fasta branch January 1, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running summarizeFasta on just noncoding peptides
2 participants