Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summarizeFasta that summarize table keys not determined correctly with source comb in --order-source #828

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Nov 15, 2023

Description

Also added a couple of test cases.

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

…f source combination is specified in --order-source
@zhuchcn zhuchcn requested a review from lydiayliu November 15, 2023 12:42
@zhuchcn zhuchcn marked this pull request as ready for review November 15, 2023 12:42
@zhuchcn zhuchcn merged commit d124e3c into main Nov 15, 2023
@zhuchcn zhuchcn deleted the czhu-fix-summarize-fasta branch November 15, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants