Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test case added to confirm that source combinations of more than 2 in --order-source is handled #825

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented Nov 13, 2023

Description

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

@zhuchcn zhuchcn requested a review from lydiayliu November 13, 2023 07:05
@zhuchcn zhuchcn marked this pull request as ready for review November 13, 2023 08:31
Copy link
Collaborator

@lydiayliu lydiayliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm, in this test case, the peptide is supposed to be put into altSplice-Noncoding-additional

@zhuchcn
Copy link
Member Author

zhuchcn commented Nov 14, 2023

To confirm, in this test case, the peptide is supposed to be put into altSplice-Noncoding-additional

Yes because the max_groups is set to 2, otherwise it will be put into altSplice-Noncoding-ALT

@zhuchcn zhuchcn merged commit b084bb4 into main Nov 14, 2023
@zhuchcn zhuchcn deleted the czhu-fix-split-fasta branch November 14, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants