-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add strand flip check #67
Conversation
For those who are interested, check out the rendered manual: And the rendered User Guide vignette: |
@@ -21,7 +21,7 @@ validate.vcf.input <- function(vcf.data) { | |||
|
|||
} | |||
|
|||
validate.pgs.data.input <- function(pgs.weight.data, use.external.effect.allele.frequency) { | |||
validate.pgs.data.input <- function(pgs.weight.data, use.external.effect.allele.frequency, correct.strand.flips, remove.ambiguous.allele.matches, remove.mismatched.indels) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These boolean flag arguments are a good opportunity to add clarity and establish default functionality. Just adding TRUE
or FALSE
defaults might go a long way here to implying the primary use case(s).
EDIT: Nevermind. Seems like you do that on the higher-level function. That's ideal. Sorry!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think all possible cases have been addressed!
Thanks everyone! @forbiddenpersimmon @dan-knight next PR will be coming soon, and it's gonna be a release PR for new version and checks for next CRAN submission |
This PR adds allele match checking and strand flip correction functionality.
For some background on strand flipping, check out my new discussion post:
#68
@RoniHaas I would appreciate your review of the key strand flip function (
assess.pgs.vcf.allele.match
)Closes #63
apply.polygenic.score
functionI have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
I have added the changes included in this pull request to
NEWS
under the next release version or unreleased, and updated the date.I have updated the version number in
metadata.yaml
andDESCRIPTION
.Both
R CMD build
andR CMD check
run successfully.Testing Results
All unit tests pass