Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop bed conversion #4

Merged
merged 19 commits into from
Jan 9, 2024
Merged

Conversation

alkaZeltser
Copy link
Collaborator

BED Conversion

This PR contains

  • Functions for converting a PGS weight file to a BED file

  • Functions for merging multiple BED files into one BED file, collapsing overlapping SNP coordinates

  • Unit tests for both of the above

  • Test data for the unit tests

  • man pages documenting the above functions

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added the changes included in this pull request to NEWS under the next release version or unreleased, and updated the date.

  • I have updated the version number in metadata.yaml and DESCRIPTION.

  • Both R CMD build and R CMD check run successfully.

Testing Results

All unit tests pass.

══ Results ═══════════════════════════════════════════════════════════════════════════════════════════════
Duration: 0.6 s

[ FAIL 0 | WARN 6 | SKIP 0 | PASS 72 ]

Copy link

@forbiddenpersimmon forbiddenpersimmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code itself looks good and unit tests were thorough. Just left some formatting fixes for you to do before merging.

@alkaZeltser alkaZeltser merged commit 279bd33 into main Jan 9, 2024
3 checks passed
@alkaZeltser alkaZeltser deleted the nzeltser-develop-bed-conversion branch January 9, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants