Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sneha/update hack email #396

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Sneha/update hack email #396

merged 2 commits into from
Jan 28, 2024

Conversation

snehaagar2023
Copy link
Contributor

Update Hack Email to hack@uclaacm.com

Fixes issue #366

@github-actions github-actions bot added documentation Improvements or additions to documentation infra Related to build/deployment infrastructure homepage The homepage workshops labels Jan 22, 2024
@snehaagar2023 snehaagar2023 changed the base branch from main to dev January 22, 2024 00:52
Copy link
Contributor

@katelynsyu katelynsyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the hack bot email in the announcements.yml needs to be changed, but I'll get back to you on that

Update: the email should be updated because the previous email is deprecated. This hack bot email is a placeholder/dummy email, just used by GitHub to track who is committing and pushing, and it's better than using someone's personal email which would lose permissions later

Copy link
Contributor

@katelynsyu katelynsyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Note: upon merge, we have to change the Hack Bot email permissions (uclaacmhack+ghbot@gmail.com -> hack+ghbot@uclaacm.com)

Base automatically changed from dev to main January 23, 2024 01:17
@nathanzzhang nathanzzhang changed the base branch from main to dev January 23, 2024 01:21
@github-actions github-actions bot removed infra Related to build/deployment infrastructure workshops labels Jan 28, 2024
@nathanzzhang nathanzzhang self-requested a review January 28, 2024 23:44
Copy link
Contributor

@nathanzzhang nathanzzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@snehaagar2023 snehaagar2023 merged commit f6c77db into dev Jan 28, 2024
2 checks passed
@snehaagar2023 snehaagar2023 deleted the sneha/updateHackEmail branch January 28, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation homepage The homepage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants