Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump react-scripts from 4.0.3 to 5.0.0 #85

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bump react-scripts from 4.0.3 to 5.0.0 #85

wants to merge 3 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 1, 2022 •
edited
Loading

Bumps react-scripts from 4.0.3 to 5.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Jan 1, 2022
@doubleiis02
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from 6bdacfd to 2c1a6da Compare January 16, 2022 21:39
@doubleiis02
Copy link
Contributor

@dependabot recreate

@dependabot
Bump react-scripts from 4.0.3 to 5.0.0
c96fad0 
Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.0/packages/react-scripts)

---
updated-dependencies:
- dependency-name: react-scripts
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/react-scripts-5.0.0 branch from 2f124ca to c96fad0 Compare January 16, 2022 21:45
@mattxwang
Copy link
Member

See - facebook/create-react-app#11930

@mattxwang
Copy link
Member

Hm, so implementing the above causes a different issue with SVGs:

yarn run v1.22.17
$ react-scripts build
Creating an optimized production build...
Failed to compile.

SyntaxError: unknown: Namespace tags are not supported by default. React's JSX doesn't support namespace tags. You can set throwIfNamespace: false to bypass this warning.
6 | ...props
7 | }, svgRef) {
8 | return <svg xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:cc="http://creativecommons.org/ns#" xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#" xmlns:svg="http://www.w3.org/2000/svg" xmlns="http://www.w3.org/2000/svg" xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" id="svg2" xmlSpace="preserve" width={671.78668} height={671.78668} viewBox="0 0 671.78668 671.78668" sodipodi:docname="instagram-new-2016-seeklogo.com.eps" ref={svgRef} aria-labelledby={titleId} {...props}>{title ? <title id={titleId}>{title}</title> : null}rdf:RDF<cc:Work rdf:about="">dc:format{"image/svg+xml"}</dc:format><dc:type rdf:resource="http://purl.org/dc/dcmitype/StillImage" /></cc:Work></rdf:RDF><sodipodi:namedview pagecolor="#000000" bordercolor="#000000" borderopacity={1} objecttolerance={10} gridtolerance={10} guidetolerance={10} inkscape:pageopacity={0} inkscape:pageshadow={2} inkscape:window-width={640} inkscape:window-height={480} id="namedview4" /><path d="m 2519.21,5038.41 c -684.18,0 -769.97,-2.9 -1038.67,-15.16 C 1212.4,5011.02 1029.27,4968.43 869.027,4906.16 703.367,4841.78 562.879,4755.64 422.824,4615.59 282.773,4475.54 196.633,4335.04 132.254,4169.38 69.9805,4009.14 27.3945,3826.01 15.1563,3557.87 2.89844,3289.17 0,3203.38 0,2519.2 0,1835.03 2.89844,1749.24 15.1563,1480.54 27.3945,1212.4 69.9805,1029.27 132.254,869.031 196.633,703.371 282.773,562.879 422.824,422.82 562.879,282.77 703.367,196.629 869.027,132.25 1029.27,69.9805 1212.4,27.3906 1480.54,15.1602 1749.24,2.90234 1835.03,0 2519.21,0 c 684.17,0 769.96,2.90234 1038.66,15.1602 268.14,12.2304 451.27,54.8203 611.51,117.0898 165.66,64.379 306.15,150.52 446.21,290.57 140.05,140.059 226.19,280.551 290.57,446.211 62.27,160.239 104.86,343.369 117.09,611.509 12.26,268.7 15.16,354.49 15.16,1038.66 0,684.18 -2.9,769.97 -15.16,1038.67 -12.23,268.14 -54.82,451.27 -117.09,611.51 -64.38,165.66 -150.52,306.16 -290.57,446.21 -140.06,140.05 -280.55,226.19 -446.21,290.57 -160.24,62.27 -343.37,104.86 -611.51,117.09 -268.7,12.26 -354.49,15.16 -1038.66,15.16 z m 0,-453.91 c 672.65,0 752.33,-2.57 1017.97,-14.69 245.62,-11.2 379.01,-52.24 467.78,-86.74 117.59,-45.7 201.51,-100.29 289.66,-188.44 88.16,-88.16 142.75,-172.08 188.45,-289.67 34.5,-88.77 75.54,-222.16 86.74,-467.78 12.12,-265.64 14.69,-345.32 14.69,-1017.98 0,-672.65 -2.57,-752.33 -14.69,-1017.97 -11.2,-245.62 -52.24,-379.01 -86.74,-467.78 -45.7,-117.591 -100.29,-201.509 -188.45,-289.661 -88.15,-88.16 -172.07,-142.75 -289.66,-188.449 -88.77,-34.5 -222.16,-75.539 -467.78,-86.738 -265.6,-12.122 -345.27,-14.692 -1017.97,-14.692 -672.71,0 -752.37,2.57 -1017.98,14.692 -245.62,11.199 -379.01,52.238 -467.78,86.738 -117.591,45.699 -201.509,100.289 -289.661,188.449 -88.152,88.152 -142.75,172.07 -188.449,289.661 -34.5,88.77 -75.535,222.16 -86.742,467.78 -12.121,265.64 -14.688,345.32 -14.688,1017.97 0,672.66 2.567,752.34 14.688,1017.98 11.207,245.62 52.242,379.01 86.742,467.78 45.699,117.59 100.293,201.51 188.445,289.66 88.156,88.16 172.074,142.75 289.665,188.45 88.77,34.5 222.16,75.54 467.78,86.74 265.64,12.12 345.32,14.69 1017.98,14.69" style={{
| ^^^^^^^^
9 | fill: "#000000",
10 | fillOpacity: 1,
11 | fillRule: "nonzero",

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Looking on SO, maybe the SVGs need to be regenerated?

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 1, 2022

A newer version of react-scripts exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doubleiis02 @mattxwang