-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Responsive search result buttons #120
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far, i like how you utilized the @media
feature! I left suggestions on how to consolidate the code and get rid of some redundancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarified one of my requests from before 😅
I added a filter and result button when the website is viewed on phone based on the Figma design. It will display filter options or the result depending on which button is selected(has a toggle behavior).
I think there should be a simpler way of displaying ResultsBody and filters-container instead of having a phone and desktop version, but I couldn't think of a way to do it.