Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive search result buttons #120

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

samgivian
Copy link
Contributor

I added a filter and result button when the website is viewed on phone based on the Figma design. It will display filter options or the result depending on which button is selected(has a toggle behavior).
I think there should be a simpler way of displaying ResultsBody and filters-container instead of having a phone and desktop version, but I couldn't think of a way to do it.

@reginawang3495 reginawang3495 linked an issue Feb 8, 2022 that may be closed by this pull request
@doubleiis02 doubleiis02 self-requested a review February 9, 2022 07:38
Copy link
Contributor

@doubleiis02 doubleiis02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far, i like how you utilized the @media feature! I left suggestions on how to consolidate the code and get rid of some redundancy.

src/components/SearchOptions/SearchOptions.js Outdated Show resolved Hide resolved
src/pages/Results/Results.js Outdated Show resolved Hide resolved
src/pages/Results/Results.js Outdated Show resolved Hide resolved
@samgivian samgivian requested a review from doubleiis02 March 2, 2022 06:16
@samgivian samgivian self-assigned this Mar 4, 2022
Copy link
Contributor

@doubleiis02 doubleiis02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarified one of my requests from before 😅

src/components/ResultSection/ResultSection.css Outdated Show resolved Hide resolved
src/components/ResultSection/ResultSection.js Outdated Show resolved Hide resolved
@samgivian samgivian requested a review from doubleiis02 March 21, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve mobile design
2 participants