Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Job to IRSA #53

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Export Job to IRSA #53

merged 6 commits into from
Nov 13, 2024

Conversation

EliseCastle23
Copy link
Contributor

@EliseCastle23 EliseCastle23 commented Apr 24, 2024

changing the export job to use environment variables and IRSA instead of access keys

Add these:

"serviceAccountName": "batch-export-sa"...


      - name: BUCKET
        valueFrom:
           configMapKeyRef:
            name: batch-export-g3auto
            key: bucket_name

Remove the following:

       "volumeMounts": [
          {
            "name": "batch-export-creds-volume",
            "readOnly": true,
            "mountPath": "/batch-export-creds.json",
            "subPath": "config.json"
          }
        ],
      },
      "volumes": [
        {
          "name": "batch-export-creds-volume",
          "secret": {
            "secretName": "batch-export-g3auto"
          }
        }
      ],

Improvements

changing the batch export job to use IRSA instead of access keys. Also, changing the job to use environment variables to read in the bucket name for the batch export job.

Deployment changes

Manifest.json files MUST be changed to use the new "batch-export-sa" service account and the "BUCKET" environment variable must be set to the batch-export-g3auto secret with the "bucket_name" key. You also no longer need to mount the batch-export-g3auto secret as this is now deprecated (it is replaced by the batch-export-g3auto configmap).

Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants