-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIDRC-927 Amazon Linux 2 image #2
base: tag-24.3.5
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor questions. Looks good to me.
|
||
# Make sure the en_US locale has been generated (required for | ||
# case-insensitive comparison of strings with accents) | ||
RUN echo "en_US.UTF-8 UTF-8" > /etc/locale.gen | ||
RUN locale-gen | ||
# (pauline 02/2025) The lines below don't work, but everything seems to work fine without this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain what you mean by this? Why don't they work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to translate this:
RUN echo "en_US.UTF-8 UTF-8" > /etc/locale.gen
RUN locale-gen
to an amazon linux install, but the installation doesn't work. I commented it out to possibly get back to it later, but everything works fine without it
|
||
# ===> https://github.com/orthanc-server/orthanc-builder/blob/11d6930/docker/orthanc/Dockerfile.builder-base | ||
################## | ||
# The dockerfile below is copied+adapted from docker/orthanc/Dockerfile.builder-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why do we need another text block explaining the same thing as on the top?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
runner-base and builder-base - 2 different images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ ✅
|
||
|
||
# always create an 'orthanc' group (gid=999) and an orthanc user (uid=999) | ||
# always create an 'orthanc' group (gid=1000) and an orthanc user (uid=1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any specific reason we change the gid and uid from 999 to 1000?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
999 was already used by something else (i don't remember what off the top of my head), so i chose to match this
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/MIDRC-927
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes