From 7275d65827734be3d94e8da9b910a9869f887281 Mon Sep 17 00:00:00 2001 From: Alexander VanTol Date: Tue, 12 Jun 2018 11:37:57 -0500 Subject: [PATCH] fix(google-url-signing): fix incorrect reversed logic on expiration times (#243) PXD-286 --- fence/blueprints/data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fence/blueprints/data.py b/fence/blueprints/data.py index 2c3504361..ed06bf171 100644 --- a/fence/blueprints/data.py +++ b/fence/blueprints/data.py @@ -374,7 +374,7 @@ def _generate_google_storage_signed_url( # If our scheduled maintainence script removes the url-signing key # before the expiration of the url then the url will NOT work # (even though the url itself isn't expired) - if key_db_entry and key_db_entry.expires > expiration_time: + if key_db_entry and key_db_entry.expires < expiration_time: private_key = create_primary_service_account_key( user_id=user_id, username=username,