Skip to content

Commit

Permalink
fix(google-url-signing): fix incorrect reversed logic on expiration t…
Browse files Browse the repository at this point in the history
…imes (#243)

PXD-286
  • Loading branch information
Avantol13 authored Jun 12, 2018
1 parent aa26c99 commit 7275d65
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fence/blueprints/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def _generate_google_storage_signed_url(
# If our scheduled maintainence script removes the url-signing key
# before the expiration of the url then the url will NOT work
# (even though the url itself isn't expired)
if key_db_entry and key_db_entry.expires > expiration_time:
if key_db_entry and key_db_entry.expires < expiration_time:
private_key = create_primary_service_account_key(
user_id=user_id,
username=username,
Expand Down

0 comments on commit 7275d65

Please sign in to comment.