Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: baseProbability typo #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: baseProbability typo #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions swim/heal_via_discover_provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ import (
type discoverProviderHealer struct {
node *Node

baseProbabillity float64
baseProbability float64
period time.Duration

previousHostListSize int
Expand All @@ -53,7 +53,7 @@ type discoverProviderHealer struct {
func newDiscoverProviderHealer(n *Node, baseProbability float64, period time.Duration) *discoverProviderHealer {
return &discoverProviderHealer{
node: n,
baseProbabillity: baseProbability,
baseProbability: baseProbability,
period: period,
logger: logging.Logger("healer").WithField("local", n.Address()),
started: make(chan struct{}, 1),
Expand Down Expand Up @@ -111,7 +111,7 @@ func (h *discoverProviderHealer) Probability() float64 {
if h.previousHostListSize < 1 {
h.previousHostListSize = 1
}
return h.baseProbabillity / float64(h.previousHostListSize)
return h.baseProbability / float64(h.previousHostListSize)
}

// Heal iterates over the hostList that the discoverProvider provides. If the
Expand Down
12 changes: 6 additions & 6 deletions swim/node.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,14 @@ type Options struct {

// When started, the partition healing algorithm attempts a partition heal
// every PartitionHealPeriod with a probability of:
// PartitionHealBaseProbabillity / # Nodes in discoverProvider.
// PartitionHealBaseProbability / # Nodes in discoverProvider.
//
// When in a 100 node cluster BaseProbabillity = 3 and Period = 30s,
// When in a 100 node cluster BaseProbability = 3 and Period = 30s,
// every 30 seconds a node will have a probability of 3/100 to start the
// partition healing procedure. This means that for the entire cluster
// the discover provider receives 6 calls per minute on average.
PartitionHealPeriod time.Duration
PartitionHealBaseProbabillity float64
PartitionHealBaseProbability float64

LabelLimits LabelOptions
InitialLabels LabelMap
Expand Down Expand Up @@ -99,7 +99,7 @@ func defaultOptions() *Options {
RollupMaxUpdates: 250,

PartitionHealPeriod: 30 * time.Second,
PartitionHealBaseProbabillity: 3,
PartitionHealBaseProbability: 3,

LabelLimits: DefaultLabelOptions,

Expand Down Expand Up @@ -132,7 +132,7 @@ func mergeDefaultOptions(opts *Options) *Options {

opts.PartitionHealPeriod = util.SelectDuration(opts.PartitionHealPeriod, def.PartitionHealPeriod)

opts.PartitionHealBaseProbabillity = util.SelectFloat(opts.PartitionHealBaseProbabillity, def.PartitionHealBaseProbabillity)
opts.PartitionHealBaseProbability = util.SelectFloat(opts.PartitionHealBaseProbability, def.PartitionHealBaseProbability)

opts.JoinTimeout = util.SelectDuration(opts.JoinTimeout, def.JoinTimeout)
opts.PingTimeout = util.SelectDuration(opts.PingTimeout, def.PingTimeout)
Expand Down Expand Up @@ -262,7 +262,7 @@ func NewNode(app, address string, channel shared.SubChannel, opts *Options) *Nod

node.healer = newDiscoverProviderHealer(
node,
opts.PartitionHealBaseProbabillity,
opts.PartitionHealBaseProbability,
opts.PartitionHealPeriod,
)
node.gossip = newGossip(node, opts.MinProtocolPeriod)
Expand Down