Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for read-only computed property in class #268

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

sidepelican
Copy link
Collaborator

The issue in #245 was secondarily solved by #267 .

This PR adds tests for the case described in issue #245.

@sidepelican sidepelican requested review from uhooi and fummicc1 October 26, 2024 12:27
Copy link
Collaborator

@fummicc1 fummicc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sidepelican sidepelican merged commit 2628c64 into uber:master Oct 26, 2024
3 checks passed
@sidepelican sidepelican deleted the 245 branch October 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants