Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct the
throws
clause in the closure within template logic to support TypedThrow. #262Correct the
throws
clause in the closure within template logic to support TypedThrow. #262Changes from all commits
199c2ef
aa0e097
2e7259b
725c67d
7f7028a
e3a2da8
2a7a57d
96add24
72a125d
0194530
3acc4a7
c28c027
0028467
802bed7
ee6da9a
c011048
62cbd3c
909d26e
75a0f36
bac0c69
f4406dd
fa5ccbb
c004716
de89895
1b1de5d
f112110
71d6920
733771e
be998e1
4a3a54a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It want to avoid relying on internal implementations.
(This snippet exists in the other 2 places. Maybe it's a time to add utility, not must)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds nice! I fixed it in these 2 commits.