Correct the throws clause in the closure within template logic to support TypedThrow.
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fummicc1
force-pushed
the
feature/issue-261-typed-throw
branch
from
136cdd3 to
bbb6de0
Compare
fummicc1
force-pushed
the
feature/issue-261-typed-throw
branch
from
c5c877f to
725c67d
Compare
fummicc1
commented
Jul 15, 2024
sidepelican
requested changes
Jul 30, 2024
Co-authored-by: Iceman <side.junktown@gmail.com>
fummicc1
commented
Oct 26, 2024
Sources/MockoloFramework/Templates/FunctionSuffixTemplate.swift
Outdated
Show resolved
Hide resolved
fummicc1
commented
Oct 26, 2024
sidepelican
reviewed
Oct 26, 2024
sidepelican
reviewed
Oct 27, 2024
| @@ -566,7 +566,7 @@ public final class SwiftType { | |||
|
|
|||
| let suffixStr = [ | |||
| isAsync ? String.async + " " : nil, | |||
| throwing.hasError ? String.throws + " " : nil, | |||
| throwing != .none ? throwing.applyThrowingTemplate()! + " " : nil, | |||
| ].compactMap { $0 }.joined() | |||
|
|
|||
There was a problem hiding this comment.
It want to avoid relying on internal implementations.
let suffixStr = [
isAsync ? String.async : nil,
throwing.applyThrowingTemplate(),
].compactMap { $0 }.joined(separator: " ") + " "(This snippet exists in the other 2 places. Maybe it's a time to add utility, not must)
fummicc1
changed the title
throws clause in the closure within template logic to support TypedThrow.
sidepelican
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I fixed tiny bug to support typed throw for closure handler. Also, added some changes as nits.