Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified the GCS Backend to use transferManager package for Downloads in Parallel #367

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Modified the GCS Backend to use transferManager package for Downloads in Parallel #367

wants to merge 3 commits into from

Conversation

gkeesh7
Copy link
Collaborator

@gkeesh7 gkeesh7 commented Oct 1, 2024 •
edited
Loading

  • There was an issue with Large Blob Downloads failing because they were exceeding the buffer Guard config in the GCSBackend.
  • This change addressed that by doing the following modifications

Modifications

  1. Added the dependency of Transfer Manager package.
  2. Updated the GCSImpl to have a *transfermanager.Downloaderfield
  3. Modified the GCSImpl download function to make use of the Downloader.

@gkeesh7 gkeesh7 added the bug Something isn't working label Oct 1, 2024
@gkeesh7 gkeesh7 self-assigned this Oct 1, 2024
@gkeesh7 gkeesh7 requested a review from zachcheu October 1, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fergusn fergusn Awaiting requested review from fergusn

@dmonojit dmonojit Awaiting requested review from dmonojit

@radicmilos radicmilos Awaiting requested review from radicmilos

@evelynl94 evelynl94 Awaiting requested review from evelynl94

@Anton-Kalpakchiev Anton-Kalpakchiev Awaiting requested review from Anton-Kalpakchiev

@xinlongz1 xinlongz1 Awaiting requested review from xinlongz1

@zachcheu zachcheu Awaiting requested review from zachcheu

Assignees

@gkeesh7 gkeesh7

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkeesh7 @gauravkuber