Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds system testing workflow to github actions #75

Merged
merged 27 commits into from
Jun 21, 2023

Conversation

ManavalanG
Copy link
Member

@ManavalanG ManavalanG commented May 31, 2023

Pull request

Please fill in the checklist below and comment as needed.

  • Was code modified? Briefly describe. Yes. System testing github actions workflow was added.
  • Was documentation modified? Briefly describe. No.
  • Is this a bug-fix? Briefly describe. No.
  • Is this a feature addition? Briefly describe. Yes. See description above.
  • Did you modify QuaC-Watch config file? If so, did you modify multiqc template
    configs/multiqc_config_template.jinja2 and script src/quac_watch/create_mutliqc_configs.py as necessary? No.
  • Did you perform system-level testing manually as described in master readme doc? Did it pass completely? If not why? No, as this is now done using github actions
  • Updated Changelog.md file with change logs in recommended format? Yes.

Anything else reviewer should know?

No.

@ManavalanG ManavalanG changed the title Cicd system testing Adds system testing workflow to gith May 31, 2023
@ManavalanG ManavalanG changed the title Adds system testing workflow to gith Adds system testing workflow to github actions May 31, 2023
@ManavalanG ManavalanG requested a review from wilkb777 May 31, 2023 16:03
…m_testing

# Conflicts:
#	docs/Changelog.md
Copy link
Member

@wilkb777 wilkb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManavalanG
Copy link
Member Author

Suddenly github actions for system testing keep failing, even though no changes have been made to concerning source code. It is unclear why this is happening :(

I got access to to larger runners but learnt later that they are not free to use. Relevant snippet:

* For larger runners, there is no additional cost for configurations that assign public static IP addresses to a larger runner. For more information on larger runners, see "Using larger runners."
* Entitlement minutes cannot be used for larger runners.
* The larger runners are not free for public repositories.
[4:56](https://cgds-uab.slack.com/archives/GTSEU473K/p1686866168293039)

I will get around to debugging the issue some day :(

@ManavalanG
Copy link
Member Author

@wilkb777 Github actions workflow for system testing began failing despite no significant code changes, and the error had to do with lack of storage space. It is unclear why it worked before but started failing of late. I reran a workflow that had succeeded before, and it still errored out. After a series of debugging efforts (documented in #78), storage in the runners were freed first before running the github actions workflow. This resulted in resolving the issue.

So overall, I added a step in github actions workflow for system testing to free up disk storage space. Could you review the changes please? :)

@ManavalanG ManavalanG merged commit 6eab6c9 into joss_manuscript Jun 21, 2023
@ManavalanG ManavalanG deleted the cicd_system_testing branch June 21, 2023 17:45
@ManavalanG ManavalanG mentioned this pull request Jun 30, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants